fix: validate JWT token on alias look ahead #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in order to ensure proper MFA for alias lookahead
benashz
force-pushed
the
VAULT-3609/verify-jwt-on-alias-lookahead
branch
from
bfe33c2 to
ad78abe
Compare
calvn
reviewed
Sep 28, 2021
scripts/update_deps.sh
Outdated
| @@ -1,37 +0,0 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
I wonder if the script changes should be a separate PR to make the backport/cherry-picking process easier.
There was a problem hiding this comment.
Fixed. Moved to #115
benashz
force-pushed
the
VAULT-3609/verify-jwt-on-alias-lookahead
branch
from
ad78abe to
16aa741
Compare
tvoran
approved these changes
Sep 29, 2021
tomhjp
approved these changes
Sep 29, 2021
tomhjp
approved these changes
Sep 29, 2021
benashz
added a commit
that referenced
this pull request
Sep 29, 2021
- in order to ensure proper validation for alias look ahead the provided JWT token must match the role's configuration.
Merged
benashz
added a commit
that referenced
this pull request
Sep 29, 2021
benashz
added a commit
that referenced
this pull request
Sep 29, 2021
This was referenced Sep 29, 2021
benashz
added a commit
that referenced
this pull request
Sep 30, 2021
benashz
added a commit
that referenced
this pull request
Sep 30, 2021
benashz
added a commit
that referenced
this pull request
Oct 1, 2021
benashz
added a commit
that referenced
this pull request
Oct 1, 2021
benashz
added a commit
that referenced
this pull request
Oct 1, 2021
benashz
added a commit
that referenced
this pull request
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for validating that a request's JWT token contains the required claims for the bound role.
Design of Change
Validate the JWT token against a known Vault role. If it is deemed to be invalid return an error.
Note: the token is not passed to Kubernetes token review API, as this is only needed for login.