-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades dependencies, adds environment bootstrap #65
Conversation
I still need to update the readme. Will do that tomorrow. |
After fixing my ssh key env this terraform setup and tests all worked great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on helpdesk to get access to an Azure account to test the full setup but it looks good!
TEST?=$$(go list ./...) | ||
EXTERNAL_TOOLS= | ||
BUILD_TAGS?=${TOOL} | ||
GOFMT_FILES?=$$(find . -name '*.go' | grep -v vendor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be curious to know which makefile vars & targets are deprecated. I hesitated to remove stuff like quickdev, testcompile & others because I wasn't sure if it was part of some CI. But if we know for some it's not part of anyone's wofkflow I'd add the Makefile clean-up in the ACs of the engineering improvement initiative.
LGTM, important comments are addressed and as for:
|
Overview
This PR upgrades dependencies, tooling, and adds development environment automation. Changes in this PR align this repo with tooling in the Vault plugin scaffold.
Local environment bootstrap usage:
make setup-env source ./bootstrap/terraform/local_environment_setup.sh make configure make teardown-env
Test Results:
Note that there aren't acceptance tests that actually use Azure resources in this plugin, so that's omitted from this description.
Contributor Checklist