-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sdk and fix login #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm sorry if I broke this, but thanks for fixing it.
The approach broadly makes sense to me, but admittedly I don't claim to be an AliCloud expert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for diving into this one. I have a couple of questions around resolving the role related to the nonce reuse issue and rework of the CLI login params.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Update dependencies and fix login.
Login was likely broken since #37 which added the
pathLoginResolveRole
method.pathLoginResolveRole
gets called before the call topathLoginUpdate
. Since we are capturing the signed GetCallerIdentity request here bothpathLoginResolveRole
andpathLoginUpdate
use the same nonce that was generated once on the vault login call.Some notes (updated):
role
is now a required field by the login pathrole
and parsed it from the GetCallerIdentity request, but the documentation said it was requiredrole
to avoid nonce reuse with the benefit of simplifyingpathLoginResolveRole