Add podman provisioner #11472
Merged
Add podman provisioner #11472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soapy1
force-pushed
the
podman-provisioner
branch
4 times, most recently
from
c9008f8 to
b3e16f1
Compare
soapy1
force-pushed
the
podman-provisioner
branch
3 times, most recently
from
e13b02f to
0dda080
Compare
chrisroberts
requested changes
Mar 30, 2020
There was a problem hiding this comment.
They weren't there in the original implementation, but would you add documentation blocks to the methods which are missing them (mostly in Client). The comments in the container classes should have the docker callouts removed too. One last thing to update is adding some documentation about the podman options in the website documentation.
soapy1
force-pushed
the
podman-provisioner
branch
2 times, most recently
from
c69a37c to
d54ee20
Compare
soapy1
force-pushed
the
podman-provisioner
branch
from
d54ee20 to
64ccd58
Compare
chrisroberts
requested changes
Apr 3, 2020
soapy1
force-pushed
the
podman-provisioner
branch
from
82614cf to
bcce2f7
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #11464