Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aws_db_instance to not recreate each time #874

Merged
merged 1 commit into from
Jan 28, 2015
Merged

Fix aws_db_instance to not recreate each time #874

merged 1 commit into from
Jan 28, 2015

Commits on Jan 28, 2015

  1. Fix aws_db_instance to not recreate each time 

    Several of the arguments were optional, and if omitted, they are
calculated. Mark them as such in the schema to avoid triggering an
update.

Go back to storing the password in the state file. Without doing so,
there's no way for Terraform to know the password has changed. It should
be hashed, but then interpolating the password yields a hash instead of
the password.

Make the `name` parameter optional. It's not required in any engine, and
in some (MS SQL Server) it's not allowed at all.

Drop the `skip_final_snapshot` argument. If `final_snapshot_identifier`
isn't specified, then don't make a final snapshot. As things were, it
was possible to create a resource with neither of these arguments
specified which would later fail when it was to be deleted since the RDS
API requires exactly one of the two.

Resolves issue hashicorp#689.
    Phil Frost committed Jan 28, 2015
    Configuration menu
    Copy the full SHA
    254b25a View commit details
    Browse the repository at this point in the history