Adding CRUD support for Customer Gateway for AWS VPC. #838
Conversation
|
Check #787 for the initial PR and comments. |
|
@mitchellh, I did not exactly understand why partial state mode is required in Create, as you had mentioned in your comment? |
|
I'm getting a merge conflict, but this looks good otherwise. Can you fix that (rebase and push up) and I'll take another look? |
mitchellh
added
the
waiting-response
|
Bump. I want this. |
|
@yahyapo We've also nearly completed migrating all our AWS resources to https://github.com/hashicorp/aws-sdk-go . If possible, you could upgrade this resource to the new library, but I doubt it will be a blocker for merging. |
/cc @sethvargo Prior to this commit, we'd only persist the result of calling Input if any input was given (len(result) > 0). The result was that every module would also repeat asking for input even if there was no input to be asked for. This commit makes it so that if no input was received, we still set a sentinel so that modules don't re-ask.
/cc @sethvargo This was causing a race with whichever provider was configured first would "win" the configuration slot. We need to make sure to append the unique provider name to the end of the key. Note: this doesn't have tests. We don't test this yet. :(
go's ssh package now lives canonically at `golang.org/x/crypto/ssh` see https://godoc.org/golang.org/x/crypto/ssh closes hashicorp#1179
|
I am raising a new PR with the correct changes. Something has gone really wonky with this one. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This solves part of #551. AWS makes bgp_asn compulsory in its API. This is used for a dynamic gateway. However, if you want to create a static gateway, you need to pass a dummy bgp_asn. Hence, I have made bgp_asn field optional and given it a default value of 65000.