Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Update paramter for DB Option Group #6558

Merged
merged 1 commit into from
May 9, 2016

Conversation

catsby
Copy link
Contributor

@catsby catsby commented May 9, 2016

aws_db_option_group was recently added in #4401, however a test therein that was added to DB Instance used a presumably old parameter name option_group_name instead of just name, which caused said DB Instance test to fail.

This updates the test there and I made sure the existing DB Option group ones pass as well:

Running..

==> Checking that code complies with gofmt requirements...
/Users/clint/Projects/Go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBOptionGroup_ -timeout 120m
d=== RUN   TestAccAWSDBOptionGroup_basic
--- PASS: TestAccAWSDBOptionGroup_basic (9.43s)
=== RUN   TestAccAWSDBOptionGroup_sqlServerOptionsUpdate
--- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (18.16s)
=== RUN   TestAccAWSDBOptionGroup_multipleOptions
--- PASS: TestAccAWSDBOptionGroup_multipleOptions (11.39s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    39.003s
Test:

@catsby catsby mentioned this pull request May 9, 2016
5 tasks
@jen20 jen20 merged commit 2d19957 into master May 9, 2016
@stack72
Copy link
Contributor

stack72 commented May 9, 2016

Apologies for missing this! LGTM

@jen20 jen20 deleted the b-aws-db-option-group-name branch May 9, 2016 17:33
@catsby
Copy link
Contributor Author

catsby commented May 9, 2016

No worries, you're still doing great work 😄

@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants