Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builtin: Refactor resource.Retry to clarify return #5543

Merged
merged 1 commit into from
Mar 10, 2016
Merged

builtin: Refactor resource.Retry to clarify return #5543

merged 1 commit into from
Mar 10, 2016

Commits on Mar 9, 2016

  1. builtin: Refactor resource.Retry to clarify return 

    Change the `RetryFunc` from a plain `error` return type to a
specialized `RetryError` which must decide whether it is
retryable or not.

Add `RetryableError` / `NonRetryableError` factory functions that
callers are meant to use to build up these errors.

This makes it eminently clear whether or not a given error is
retryable from inside the client code.

Goal here is to _not_ change any behavior, simply reflect the
existing behavior with the new, clearer, API.
    @phinze
    phinze committed Mar 9, 2016
    Configuration menu
    Copy the full SHA
    108ccf0 View commit details
    Browse the repository at this point in the history