provider/aws: aws_redshift_cluster publicly_accessible now defaults true

[stack72]

Fixes #5252

In a nutshell, there was no default on an optional bool. When GetOk was used with false, it wasn't sending a value to the API and therefore defaulting to true.

Changed to use AWS default of true - as redshift clusters default to the default VPC and thus are public by default

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRedshiftCluster' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
GO15VENDOREXPERIMENT=1 go generate $(GO15VENDOREXPERIMENT=1 go list ./... | grep -v /vendor/)
TF_ACC=1 GO15VENDOREXPERIMENT=1 go test ./builtin/providers/aws -v -run=TestAccAWSRedshiftCluster -timeout 120m
=== RUN   TestAccAWSRedshiftCluster_basic
--- PASS: TestAccAWSRedshiftCluster_basic (616.52s)
=== RUN   TestAccAWSRedshiftCluster_notPubliclyAccessible
--- PASS: TestAccAWSRedshiftCluster_notPubliclyAccessible (645.47s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    1262.009s

[phinze]

Solid - LGTM

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.