provider/aws: Fix copy_tags_to_snapshot for DB Instance #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work @catsby! LGTM |
|
FYI, the broken build is due to |
|
LGTM |
stack72
added a commit
that referenced
this pull request
Feb 22, 2016
provider/aws: Fix copy_tags_to_snapshot for DB Instance
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
copy_tags_to_snapshotattribute is only being applied on creation of read replicas of DB Instances. For new DBs or DBs created from a snapshot, it was only being applied after a new plan->apply, because it was only checked in the update method.This PR addresses that, applying it to all 3 creation scenarios, and expands an acceptance test to confirm this.
Fixes #5154