Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/azurerm: Add azurerm_sql_firewall_rule resource #5057

Merged
merged 1 commit into from
Feb 8, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Feb 8, 2016

make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=AzureRMSqlFirewallRule' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
GO15VENDOREXPERIMENT=1 go generate $(GO15VENDOREXPERIMENT=1 go list ./... | grep -v /vendor/)
TF_ACC=1 GO15VENDOREXPERIMENT=1 go test ./builtin/providers/azurerm -v -run=AzureRMSqlFirewallRule -timeout 120m
=== RUN   TestAccAzureRMSqlFirewallRule_basic
--- PASS: TestAccAzureRMSqlFirewallRule_basic (436.22s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    436.237s

The test includes the update of the firewall rule IP addresses

@jen20
Copy link
Contributor

jen20 commented Feb 8, 2016

LGTM. Thanks @stack72!

jen20 added a commit that referenced this pull request Feb 8, 2016
provider/azurerm: Add `azurerm_sql_firewall_rule` resource
@jen20 jen20 merged commit dad70e4 into hashicorp:master Feb 8, 2016
@stack72 stack72 deleted the azurerm-sql-firewall-rule branch February 18, 2016 21:30
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants