-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Autoscaling Group Scheduled Actions #4256
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
189 changes: 189 additions & 0 deletions
189
builtin/providers/aws/resource_aws_autoscaling_schedule.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,189 @@ | ||
package aws | ||
|
||
import ( | ||
"fmt" | ||
"log" | ||
"time" | ||
|
||
"github.com/aws/aws-sdk-go/aws" | ||
"github.com/aws/aws-sdk-go/service/autoscaling" | ||
"github.com/hashicorp/terraform/helper/schema" | ||
) | ||
|
||
const awsAutoscalingScheduleTimeLayout = "2006-01-02T15:04:05Z" | ||
|
||
func resourceAwsAutoscalingSchedule() *schema.Resource { | ||
return &schema.Resource{ | ||
Create: resourceAwsAutoscalingScheduleCreate, | ||
Read: resourceAwsAutoscalingScheduleRead, | ||
Update: resourceAwsAutoscalingScheduleCreate, | ||
Delete: resourceAwsAutoscalingScheduleDelete, | ||
|
||
Schema: map[string]*schema.Schema{ | ||
"arn": &schema.Schema{ | ||
Type: schema.TypeString, | ||
Computed: true, | ||
}, | ||
"scheduled_action_name": &schema.Schema{ | ||
Type: schema.TypeString, | ||
Required: true, | ||
ForceNew: true, | ||
}, | ||
"autoscaling_group_name": &schema.Schema{ | ||
Type: schema.TypeString, | ||
Required: true, | ||
ForceNew: true, | ||
}, | ||
"start_time": &schema.Schema{ | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Computed: true, | ||
ValidateFunc: validateASGScheduleTimestamp, | ||
}, | ||
"end_time": &schema.Schema{ | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Computed: true, | ||
ValidateFunc: validateASGScheduleTimestamp, | ||
}, | ||
"recurrence": &schema.Schema{ | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Computed: true, | ||
}, | ||
"min_size": &schema.Schema{ | ||
Type: schema.TypeInt, | ||
Optional: true, | ||
Computed: true, | ||
}, | ||
"max_size": &schema.Schema{ | ||
Type: schema.TypeInt, | ||
Optional: true, | ||
Computed: true, | ||
}, | ||
"desired_capacity": &schema.Schema{ | ||
Type: schema.TypeInt, | ||
Optional: true, | ||
Computed: true, | ||
}, | ||
}, | ||
} | ||
} | ||
|
||
func resourceAwsAutoscalingScheduleCreate(d *schema.ResourceData, meta interface{}) error { | ||
autoscalingconn := meta.(*AWSClient).autoscalingconn | ||
params := &autoscaling.PutScheduledUpdateGroupActionInput{ | ||
AutoScalingGroupName: aws.String(d.Get("autoscaling_group_name").(string)), | ||
ScheduledActionName: aws.String(d.Get("scheduled_action_name").(string)), | ||
} | ||
|
||
if attr, ok := d.GetOk("start_time"); ok { | ||
t, err := time.Parse(awsAutoscalingScheduleTimeLayout, attr.(string)) | ||
if err != nil { | ||
return fmt.Errorf("Error Parsing AWS Autoscaling Group Schedule Start Time: %s", err.Error()) | ||
} | ||
params.StartTime = aws.Time(t) | ||
} | ||
|
||
if attr, ok := d.GetOk("end_time"); ok { | ||
t, err := time.Parse(awsAutoscalingScheduleTimeLayout, attr.(string)) | ||
if err != nil { | ||
return fmt.Errorf("Error Parsing AWS Autoscaling Group Schedule End Time: %s", err.Error()) | ||
} | ||
params.EndTime = aws.Time(t) | ||
} | ||
|
||
if attr, ok := d.GetOk("recurrance"); ok { | ||
params.Recurrence = aws.String(attr.(string)) | ||
} | ||
|
||
if attr, ok := d.GetOk("min_size"); ok { | ||
params.MinSize = aws.Int64(int64(attr.(int))) | ||
} | ||
|
||
if attr, ok := d.GetOk("max_size"); ok { | ||
params.MaxSize = aws.Int64(int64(attr.(int))) | ||
} | ||
|
||
if attr, ok := d.GetOk("desired_capacity"); ok { | ||
params.DesiredCapacity = aws.Int64(int64(attr.(int))) | ||
} | ||
|
||
log.Printf("[INFO] Creating Autoscaling Scheduled Action: %s", d.Get("scheduled_action_name").(string)) | ||
_, err := autoscalingconn.PutScheduledUpdateGroupAction(params) | ||
if err != nil { | ||
return fmt.Errorf("Error Creating Autoscaling Scheduled Action: %s", err.Error()) | ||
} | ||
|
||
d.SetId(d.Get("scheduled_action_name").(string)) | ||
|
||
return resourceAwsAutoscalingScheduleRead(d, meta) | ||
} | ||
|
||
func resourceAwsAutoscalingScheduleRead(d *schema.ResourceData, meta interface{}) error { | ||
sa, err := resourceAwsASGScheduledActionRetrieve(d, meta) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
d.Set("autoscaling_group_name", sa.AutoScalingGroupName) | ||
d.Set("arn", sa.ScheduledActionARN) | ||
d.Set("desired_capacity", sa.DesiredCapacity) | ||
d.Set("min_size", sa.MinSize) | ||
d.Set("max_size", sa.MaxSize) | ||
d.Set("recurrance", sa.Recurrence) | ||
d.Set("start_time", sa.StartTime.Format(awsAutoscalingScheduleTimeLayout)) | ||
d.Set("end_time", sa.EndTime.Format(awsAutoscalingScheduleTimeLayout)) | ||
|
||
return nil | ||
} | ||
|
||
func resourceAwsAutoscalingScheduleDelete(d *schema.ResourceData, meta interface{}) error { | ||
autoscalingconn := meta.(*AWSClient).autoscalingconn | ||
|
||
params := &autoscaling.DeleteScheduledActionInput{ | ||
AutoScalingGroupName: aws.String(d.Get("autoscaling_group_name").(string)), | ||
ScheduledActionName: aws.String(d.Id()), | ||
} | ||
|
||
log.Printf("[INFO] Deleting Autoscaling Scheduled Action: %s", d.Id()) | ||
_, err := autoscalingconn.DeleteScheduledAction(params) | ||
if err != nil { | ||
return fmt.Errorf("Error deleting Autoscaling Scheduled Action: %s", err.Error()) | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func resourceAwsASGScheduledActionRetrieve(d *schema.ResourceData, meta interface{}) (*autoscaling.ScheduledUpdateGroupAction, error) { | ||
autoscalingconn := meta.(*AWSClient).autoscalingconn | ||
|
||
params := &autoscaling.DescribeScheduledActionsInput{ | ||
AutoScalingGroupName: aws.String(d.Get("autoscaling_group_name").(string)), | ||
ScheduledActionNames: []*string{aws.String(d.Id())}, | ||
} | ||
|
||
log.Printf("[INFO] Describing Autoscaling Scheduled Action: %+v", params) | ||
actions, err := autoscalingconn.DescribeScheduledActions(params) | ||
if err != nil { | ||
return nil, fmt.Errorf("Error retrieving Autoscaling Scheduled Actions: %s", err) | ||
} | ||
|
||
if len(actions.ScheduledUpdateGroupActions) != 1 || | ||
*actions.ScheduledUpdateGroupActions[0].ScheduledActionName != d.Id() { | ||
return nil, fmt.Errorf("Unable to find Autoscaling Scheduled Action: %#v", actions.ScheduledUpdateGroupActions) | ||
} | ||
|
||
return actions.ScheduledUpdateGroupActions[0], nil | ||
} | ||
|
||
func validateASGScheduleTimestamp(v interface{}, k string) (ws []string, errors []error) { | ||
value := v.(string) | ||
_, err := time.Parse(awsAutoscalingScheduleTimeLayout, value) | ||
if err != nil { | ||
errors = append(errors, fmt.Errorf( | ||
"%q cannot be parsed as iso8601 Timestamp Format", value)) | ||
} | ||
|
||
return | ||
} |
117 changes: 117 additions & 0 deletions
117
builtin/providers/aws/resource_aws_autoscaling_schedule_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,117 @@ | ||
package aws | ||
|
||
import ( | ||
"fmt" | ||
"testing" | ||
|
||
"github.com/aws/aws-sdk-go/aws" | ||
"github.com/aws/aws-sdk-go/service/autoscaling" | ||
"github.com/hashicorp/terraform/helper/resource" | ||
"github.com/hashicorp/terraform/terraform" | ||
) | ||
|
||
func TestAccAWSAutoscalingSchedule_basic(t *testing.T) { | ||
var schedule autoscaling.ScheduledUpdateGroupAction | ||
|
||
resource.Test(t, resource.TestCase{ | ||
PreCheck: func() { testAccPreCheck(t) }, | ||
Providers: testAccProviders, | ||
CheckDestroy: testAccCheckAWSAutoscalingScheduleDestroy, | ||
Steps: []resource.TestStep{ | ||
resource.TestStep{ | ||
Config: testAccAWSAutoscalingScheduleConfig, | ||
Check: resource.ComposeTestCheckFunc( | ||
testAccCheckScalingScheduleExists("aws_autoscaling_schedule.foobar", &schedule), | ||
), | ||
}, | ||
}, | ||
}) | ||
} | ||
|
||
func testAccCheckScalingScheduleExists(n string, policy *autoscaling.ScheduledUpdateGroupAction) resource.TestCheckFunc { | ||
return func(s *terraform.State) error { | ||
rs, ok := s.RootModule().Resources[n] | ||
if !ok { | ||
return fmt.Errorf("Not found: %s", n) | ||
} | ||
|
||
autoScalingGroup, _ := rs.Primary.Attributes["autoscaling_group_name"] | ||
conn := testAccProvider.Meta().(*AWSClient).autoscalingconn | ||
params := &autoscaling.DescribeScheduledActionsInput{ | ||
AutoScalingGroupName: aws.String(autoScalingGroup), | ||
ScheduledActionNames: []*string{aws.String(rs.Primary.ID)}, | ||
} | ||
|
||
resp, err := conn.DescribeScheduledActions(params) | ||
if err != nil { | ||
return err | ||
} | ||
if len(resp.ScheduledUpdateGroupActions) == 0 { | ||
return fmt.Errorf("Scaling Schedule not found") | ||
} | ||
|
||
return nil | ||
} | ||
} | ||
|
||
func testAccCheckAWSAutoscalingScheduleDestroy(s *terraform.State) error { | ||
conn := testAccProvider.Meta().(*AWSClient).autoscalingconn | ||
|
||
for _, rs := range s.RootModule().Resources { | ||
if rs.Type != "aws_autoscaling_schedule" { | ||
continue | ||
} | ||
|
||
autoScalingGroup, _ := rs.Primary.Attributes["autoscaling_group_name"] | ||
params := &autoscaling.DescribeScheduledActionsInput{ | ||
AutoScalingGroupName: aws.String(autoScalingGroup), | ||
ScheduledActionNames: []*string{aws.String(rs.Primary.ID)}, | ||
} | ||
|
||
resp, err := conn.DescribeScheduledActions(params) | ||
|
||
if err == nil { | ||
if len(resp.ScheduledUpdateGroupActions) != 0 && | ||
*resp.ScheduledUpdateGroupActions[0].ScheduledActionName == rs.Primary.ID { | ||
return fmt.Errorf("Scaling Schedule Still Exists: %s", rs.Primary.ID) | ||
} | ||
} | ||
} | ||
|
||
return nil | ||
} | ||
|
||
var testAccAWSAutoscalingScheduleConfig = fmt.Sprintf(` | ||
resource "aws_launch_configuration" "foobar" { | ||
name = "terraform-test-foobar5" | ||
image_id = "ami-21f78e11" | ||
instance_type = "t1.micro" | ||
} | ||
|
||
resource "aws_autoscaling_group" "foobar" { | ||
availability_zones = ["us-west-2a"] | ||
name = "terraform-test-foobar5" | ||
max_size = 1 | ||
min_size = 1 | ||
health_check_grace_period = 300 | ||
health_check_type = "ELB" | ||
force_delete = true | ||
termination_policies = ["OldestInstance"] | ||
launch_configuration = "${aws_launch_configuration.foobar.name}" | ||
tag { | ||
key = "Foo" | ||
value = "foo-bar" | ||
propagate_at_launch = true | ||
} | ||
} | ||
|
||
resource "aws_autoscaling_schedule" "foobar" { | ||
scheduled_action_name = "foobar" | ||
min_size = 0 | ||
max_size = 1 | ||
desired_capacity = 0 | ||
start_time = "2016-12-11T18:00:00Z" | ||
end_time = "2016-12-12T06:00:00Z" | ||
autoscaling_group_name = "${aws_autoscaling_group.foobar.name}" | ||
} | ||
`) |
55 changes: 55 additions & 0 deletions
55
website/source/docs/providers/aws/r/autoscaling_schedule.html.markdown
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
--- | ||
layout: "aws" | ||
page_title: "AWS: aws_autoscaling_schedule" | ||
sidebar_current: "docs-aws-resource-autoscaling-schedule" | ||
description: |- | ||
Provides an AutoScaling Schedule resource. | ||
--- | ||
|
||
# aws\_autoscaling\_schedule | ||
|
||
Provides an AutoScaling Schedule resource. | ||
|
||
## Example Usage | ||
``` | ||
resource "aws_autoscaling_group" "foobar" { | ||
availability_zones = ["us-west-2a"] | ||
name = "terraform-test-foobar5" | ||
max_size = 1 | ||
min_size = 1 | ||
health_check_grace_period = 300 | ||
health_check_type = "ELB" | ||
force_delete = true | ||
termination_policies = ["OldestInstance"] | ||
} | ||
|
||
resource "aws_autoscaling_schedule" "foobar" { | ||
scheduled_action_name = "foobar" | ||
min_size = 0 | ||
max_size = 1 | ||
desired_capacity = 0 | ||
start_time = "2016-12-11T18:00:00Z" | ||
end_time = "2016-12-12T06:00:00Z" | ||
autoscaling_group_name = "${aws_autoscaling_group.foobar.name}" | ||
} | ||
``` | ||
|
||
## Argument Reference | ||
|
||
The following arguments are supported: | ||
|
||
* `autoscaling_group_name` - (Required) The name or Amazon Resource Name (ARN) of the Auto Scaling group. | ||
* `scheduled_action_name` - (Required) The name of this scaling action. | ||
* `start_time` - (Optional) The time for this action to start, in "YYYY-MM-DDThh:mm:ssZ" format in UTC/GMT only (for example, 2014-06-01T00:00:00Z ). | ||
If you try to schedule your action in the past, Auto Scaling returns an error message. | ||
* `end_time` - (Optional) The time for this action to end, in "YYYY-MM-DDThh:mm:ssZ" format in UTC/GMT only (for example, 2014-06-01T00:00:00Z ). | ||
If you try to schedule your action in the past, Auto Scaling returns an error messag | ||
* `recurrence` - (Optional) The time when recurring future actions will start. Start time is specified by the user following the Unix cron syntax format. | ||
* `min_size` - (Optional) The minimum size for the Auto Scaling group. | ||
* `max_size` - (Optional) The maximum size for the Auto Scaling group. | ||
* `desired_capacity` - (Optional) The number of EC2 instances that should be running in the group. | ||
|
||
~> **NOTE:** When `start_time` and `end_time` are specified with `recurrence` , they form the boundaries of when the recurring action will start and stop. | ||
|
||
## Attribute Reference | ||
* `arn` - The ARN assigned by AWS to the autoscaling schedule. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could make use of the (new) resource-level ValidateFunc to ensure that
end_time
>start_time
here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this hasn't yet been merged, sorry!