fix(cloud): cloud backend rendering query warning diags

[mjyocca]

Fixes an issue where any warning diagnostics generated during terraform query execution failed to render in the cloud backend session. Adds a default json log case statement to catch possible diagnostics to surface to the user.

Target Release

1.14.x

Rollback Plan

• If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

• This change is user-facing and I added a changelog entry.
• This change is not user-facing.

[dbanck]

Nice catch and thanks for raising the PR!

The JSON has a small typo which trips up the parser and the render logic afterwards. Here is where the parsing fails and the message gets emitted as regular raw CLI output:

terraform/internal/cloud/backend_query.go

Lines 124 to 133 in ade20e5

	log := &jsonformat.JSONLog{}
	if err := json.Unmarshal(line, log); err != nil {
	// If we can not parse the line as JSON, we will simply
	// print the line. This maintains backwards compatibility for
	// users who do not wish to enable structured output in their
	// workspace.
	b.CLI.Output(string(line))
	continue
	}

This prints out the whole JSON line to stdout and allows your test case to pass. Without the typo, the renderer will print a nicely formatting diagnostic message, but the test case will need an update to capture this. I left some comments inline for this.

Thanks again!

[dbanck]

Thanks 🌟

[sebasslash]

🚀 Legendary

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.