fix: parse boolean env vars in S3 backend correctly#37940
fix: parse boolean env vars in S3 backend correctly#37940jar-b merged 3 commits intohashicorp:mainfrom
Conversation
d1d6240 to
b62d97a
Compare
|
Thanks for this submission! The S3 backend is maintained by the AWS Provider team at HashiCorp, and IBM company. I have notified that team of your PR. Thanks again! |
|
@crw Thank you for getting the PR in the queue. Can we expedite this process? It has been a month since it's pending review. |
This is consistent with the `kind` used for previous breaking changes to S3 backend behavior.
jar-b
left a comment
There was a problem hiding this comment.
LGTM 🎉
% TF_ACC=1 go test -count=1 ./...
ok github.com/hashicorp/terraform/internal/backend/remote-state/s3 202.097s|
Thank you for the contribution, @vietcgi! 👍 I modified the changelog entry to an upgrade note to align with how previous breaking changes to S3 backend behavior have been documented. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Setting
AWS_USE_FIPS_ENDPOINT=falseincorrectly enables FIPS endpoints because the code treats any non-empty string as true.This fixes
boolAttrDefaultEnvVarOkto properly parse "true"/"false" (case-insensitive), matching AWS SDK behavior.Fixes #37601