actions: disable support for deferrals #37700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables deferral support for actions, hopefully temporarily.
Essentially, if an action is deferred it should retroactively mark the resource that triggered it as deferred as well. This leads to dependency problems as other resources could have already executed. The longer term fix for this is to add some kind of post plan step that can properly organise the retroactive deferrals once the outcome of all the planning is known.
For now, the rules are:
There is now logic that returns diagnostics for the above three cases, and ensures that deferrals are disallowed with sensible explanations provided.