actions: don't panic when resource change is nil - it might be a refresh #37687
Conversation
mildwonkey
added
1.4-backport
| if change == nil { | ||
| panic("change cannot be nil") | ||
| // nothing to do (this may be a refresh ) | ||
| return nil |
There was a problem hiding this comment.
We might want something more robust here eventually, having a nil change under any other circumstance is worthy of a panic (and with the refactoring that will probably continue around actions, mistakes like a missing change are even more likely)
There was a problem hiding this comment.
Perhaps we shouldn't have even gotten to this point during a refresh only plan, since actions are in effect changes, and we're promising that there can be no changes with -refresh-only.
actions: don't panic when resource change is nil - it might be a refresh This is a manual backport, I selected the wrong label.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
3 participants
@steve-hashi reported a bug where any configuration with actions would panic when running
terraform plan --refresh-only. This removes the panic, returning nil if no changes are found for the resource.Fixes #
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry