PSS: Add reusable method for obtaining the provider factory needed for accessing a state store. #37665
+263
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reading them from the deps lock file. Update calling code to accommodate this.
…ts where building binaries isn't possible
SarahFrench
added
the
no-changelog-needed
SarahFrench
commented
Sep 24, 2025
Comment on lines
+78
to
+81
| expectedProviderDescription := "This is terraform-provider-simple v6" | ||
| if s.Provider.Body.Description != expectedProviderDescription { | ||
| t.Fatalf("expected description to be %q, but got %q", expectedProviderDescription, s.Provider.Body.Description) | ||
| } |
There was a problem hiding this comment.
Here's the reason for adding descriptions to the simple providers' schemas
mildwonkey
reviewed
Sep 24, 2025
radeksimko
previously approved these changes
Sep 24, 2025
SarahFrench
commented
Sep 24, 2025
Co-authored-by: Radek Simko <[email protected]>
radeksimko
approved these changes
Sep 24, 2025
|
I'll re-run the tests |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls out reusable logic that allows calling code to obtain the necessary provider factory for launching a provider for state storage into method
getStateStoreProviderFactory.To facilitate this, we also need to allow Terraform to be able to obtain provider factories from in memory locks.
Currently the only method for obtaining factories (
providerFactories) reads in locks from the dependency lock file. This isn't sufficient in the context of PSS; new code needs to obtain a factory during a time when locks are in a pending state , i.e up-to-date locks are in memory and any existing dependency lock file is outdated and hasn't yet been updated. To unblock this we've added the newProviderFactoriesFromLocksmethod that accepts in memory locks as an argument. This is parallel to the previous method, which has been renamedproviderFactories=>ProviderFactories.Other changes in this PR:
initBackendto the point wheregetStateStoreProviderFactoryis used.Target Release
N/A
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry