Skip to content

Conversation

@dsa0x
Copy link
Member

@dsa0x dsa0x commented Sep 16, 2025

This PR ensures that when a list config isn't given a config block, terraform sends a non-null config to the provider RPC. Also, we want to validate the existence of the config block if any of its direct attribute or block is required.

Because we were already manually constructing a schema for the list block anyway, I updated that schema to make config required if its direct attribute are required.

Target Release

1.14.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@dsa0x dsa0x added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Sep 16, 2025
@dsa0x dsa0x force-pushed the sams/validate-empty-config branch from 40e25e6 to 46d0374 Compare September 16, 2025 13:24
@dsa0x dsa0x force-pushed the sams/validate-empty-config branch from 46d0374 to ffc40fa Compare September 16, 2025 13:25
@dsa0x dsa0x added the 1.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Sep 16, 2025
@dsa0x dsa0x force-pushed the sams/validate-empty-config branch 2 times, most recently from 4884439 to fade75a Compare September 16, 2025 20:00
@dsa0x dsa0x force-pushed the sams/validate-empty-config branch from fade75a to 2247707 Compare September 17, 2025 06:39
@dsa0x dsa0x marked this pull request as ready for review September 18, 2025 10:22
@dsa0x dsa0x requested a review from a team as a code owner September 18, 2025 10:22
@dsa0x dsa0x changed the title list: validate empty config list: send non-null "config" object to provider when not present in the list block Sep 18, 2025
@dsa0x dsa0x merged commit a750471 into main Sep 24, 2025
7 checks passed
@dsa0x dsa0x deleted the sams/validate-empty-config branch September 24, 2025 07:31
dsa0x added a commit that referenced this pull request Sep 24, 2025
dsa0x pushed a commit that referenced this pull request Sep 24, 2025
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants