Skip to content

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented May 7, 2025

This PR removes two resource identity validations:

  1. That an identity hasn't changed. Some resources have mutable identities, and the provider SDK can provide better safeguards and opt-out behaviour than enforcing this for every resource type in Terraform.
  2. That an identity can't contain null values. Some identities need some sort of "optional" attribute, so we won't enforce that values must be non-null. This shifts some responsibility to provider authors that a resource identity is still uniquely identifiable even with null values.

Target Release

1.12.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@dbanck dbanck added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label May 7, 2025
@dbanck dbanck requested a review from a team as a code owner May 7, 2025 11:12
@dbanck dbanck added the 1.12-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label May 7, 2025
@dbanck dbanck merged commit c3b5b84 into main May 7, 2025
10 of 12 checks passed
@dbanck dbanck deleted the dbanck/relax-identity-validation branch May 7, 2025 12:50
dbanck added a commit that referenced this pull request May 7, 2025
* Remove identity change validation

* Remove validation for null checks in identities
dbanck added a commit that referenced this pull request May 7, 2025
* Remove identity change validation

* Remove validation for null checks in identities
Maed223 pushed a commit that referenced this pull request May 13, 2025
* Remove identity change validation

* Remove validation for null checks in identities
Copy link
Contributor

github-actions bot commented Jun 7, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.12-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants