Skip to content

Conversation

@rkoron007
Copy link
Contributor

Small PR to add the provider to the example in terraform.applying and make it explicit what is going on in the code example.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@rkoron007 rkoron007 added 1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.11-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.12-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged labels Apr 29, 2025
@rkoron007 rkoron007 self-assigned this Apr 29, 2025
@rkoron007 rkoron007 requested review from a team as code owners April 29, 2025 22:33
@rkoron007 rkoron007 added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Apr 29, 2025
trujillo-adam
trujillo-adam previously approved these changes Apr 30, 2025
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions. Approving so you can move forward after reviewing them.

@rkoron007 rkoron007 requested a review from trujillo-adam April 30, 2025 16:08
@github-actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

@github-actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to fix a typo I introduced, otherwise looks good!

@rkoron007 rkoron007 merged commit f9e2f7c into main Apr 30, 2025
9 checks passed
@rkoron007 rkoron007 deleted the RK/terraform-applying-example branch April 30, 2025 20:02
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.11-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.12-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants