Skip to content

Validate identity to match identity schema #36904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 29, 2025
Merged

Validate identity to match identity schema #36904

merged 5 commits into from
Apr 29, 2025

Conversation

@dbanck
Copy link
Member

@dbanck dbanck commented Apr 17, 2025 •
edited
Loading

This PR adds a new validation that an provider-returned identity conforms to the identity schema.

Target Release

1.12.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@dbanck dbanck added no-changelog-needed Add this to your PR if the change does not require a changelog entry 1.12-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged labels Apr 17, 2025
@dsa0x dsa0x force-pushed the dbanck/validate-identity-matches-schema branch from accd5cb to d0232da Compare April 23, 2025 19:24
@dsa0x dsa0x marked this pull request as ready for review April 24, 2025 06:31
@dsa0x dsa0x requested a review from a team as a code owner April 24, 2025 06:31
mildwonkey
mildwonkey reviewed Apr 24, 2025
View reviewed changes
@dsa0x dsa0x requested review from a team and mildwonkey April 28, 2025 08:41
@dbanck dbanck force-pushed the dbanck/validate-identity-matches-schema branch from 6b10b67 to 42d428f Compare April 29, 2025 08:37
@dbanck dbanck merged commit 62c84e3 into main Apr 29, 2025
13 of 14 checks passed
@dbanck dbanck deleted the dbanck/validate-identity-matches-schema branch April 29, 2025 09:58
dbanck added a commit that referenced this pull request Apr 29, 2025
@dbanck @dsa0x
Validate identity to match identity schema (#36904)
a107df7 
* Validate identity to match identity schema

* validate on new create too  and add tests

* validate schema nesting type

* validate required attrs

* remove need for extra fn

---------

Co-authored-by: Samsondeen Dare <[email protected]>
@github-actions github-actions bot mentioned this pull request Apr 29, 2025
Merged
5 tasks
@dbanck dbanck mentioned this pull request May 5, 2025
Merged
2 tasks
@github-actions github-actions bot mentioned this pull request May 5, 2025
Merged
2 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SarahFrench SarahFrench SarahFrench approved these changes

@dsa0x dsa0x dsa0x approved these changes

@mildwonkey mildwonkey Awaiting requested review from mildwonkey

Assignees

No one assigned

Labels

1.12-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dbanck @mildwonkey @SarahFrench @dsa0x