stacks: update removed blocks to allow targeting of embedded stacks #36814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamcervante
added
the
no-changelog-needed
liamcervante
force-pushed
the
liamcervante/stacks/removed-chain-2/unknown-stack-instances
branch
from
c87fbdb to
6f07866
Compare
liamcervante
force-pushed
the
liamcervante/stacks/removed-stack
branch
from
2f0f925 to
864b92c
Compare
liamcervante
force-pushed
the
liamcervante/stacks/removed-chain-2/unknown-stack-instances
branch
from
6f07866 to
6846081
Compare
Base automatically changed from
liamcervante/stacks/removed-chain-2/unknown-stack-instances
to
main
April 3, 2025 08:40
liamcervante
force-pushed
the
liamcervante/stacks/removed-stack
branch
from
864b92c to
ec7fed5
Compare
liamcervante
force-pushed
the
liamcervante/stacks/removed-stack
branch
from
ec7fed5 to
b51b794
Compare
DanielMSchmidt
approved these changes
Apr 3, 2025
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the concept of a
RemovedStackCallinto the stacks runtime. Essentially, a removed block can now target an entire embedded stack and mark everything inside as being removed.To enable this,
Stackobjects now accept aplans.Modeas part of their constructor which the removed stack call sets to beplans.Destroywhile regular stack calls inherit from their stack. The behaviour of the removed stack call within the stack is otherwise fairly similar.This PR also refactors the dynamic walk logic to extract the now fairly complicated logic for handling components and embedded stacks into dedicated functions to tidy everything up a bit.