Skip to content

Update golang.org/x/oauth2 to v0.17.0 for Google Cloud Storage SDK compatibility#34670

Merged
alisdair merged 1 commit intohashicorp:mainfrom
bschaatsbergen:c/bump-golang-org-x-oauth2
Mar 5, 2024
Merged

Update golang.org/x/oauth2 to v0.17.0 for Google Cloud Storage SDK compatibility#34670
alisdair merged 1 commit intohashicorp:mainfrom
bschaatsbergen:c/bump-golang-org-x-oauth2

Conversation

@bschaatsbergen
Copy link
Contributor

@bschaatsbergen bschaatsbergen commented Feb 13, 2024

Closes #34234

Summary

The current implementation resolves version v0.11.0 of the golang.org/x/oauth2 package, and this update is necessary for compatibility with the Google Cloud Storage SDK, as per the token source application code in: https://github.com/hashicorp/terraform/blob/main/internal/backend/remote-state/gcs/backend.go#L148-L163

This pull request addresses an issue where we pass in (initialize) credentials of a type that isn't supported by the current (golang.org/x/oauth2/google) package we use. The missing user type: external_account_authorized_user was introduced in version v0.12.0, released in September 2023. For more details, refer to the commit: https://cs.opensource.google/go/x/oauth2/+/43b6a7ba1972152df70cd1e5ac7705e981df5f66.

Changes

  • Upgraded the golang.org/x/oauth2 package to version: v0.17.0

@crw
Copy link
Contributor

crw commented Feb 13, 2024

Thanks for the submission, I'll bring it to triage.

@bschaatsbergen
Copy link
Contributor Author

Thanks for the submission, I'll bring it to triage.

Awesome, thanks @crw

@thomas-dussouillez
Copy link

Hello ! Any news/progress on this ? It's quite blocking for us :( Thank you !

@alisdair alisdair requested a review from a team March 5, 2024 19:09
@alisdair
Copy link
Contributor

alisdair commented Mar 5, 2024

Thanks for working on this!

@alisdair alisdair merged commit 3cc43b0 into hashicorp:main Mar 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@bschaatsbergen bschaatsbergen deleted the c/bump-golang-org-x-oauth2 branch March 5, 2024 20:27
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terraform doesn't support GCP "external_account_authorized_user"

5 participants

Comments