Update golang.org/x/oauth2 to v0.17.0 for Google Cloud Storage SDK compatibility#34670
Merged
alisdair merged 1 commit intohashicorp:mainfrom Mar 5, 2024
Merged
Conversation
Contributor
|
Thanks for the submission, I'll bring it to triage. |
Contributor
Author
Awesome, thanks @crw |
bateller
approved these changes
Feb 22, 2024
|
Hello ! Any news/progress on this ? It's quite blocking for us :( Thank you ! |
alisdair
approved these changes
Mar 5, 2024
Contributor
|
Thanks for working on this! |
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34234
Summary
The current implementation resolves version
v0.11.0of the golang.org/x/oauth2 package, and this update is necessary for compatibility with the Google Cloud Storage SDK, as per the token source application code in: https://github.com/hashicorp/terraform/blob/main/internal/backend/remote-state/gcs/backend.go#L148-L163This pull request addresses an issue where we pass in (initialize) credentials of a type that isn't supported by the current (golang.org/x/oauth2/google) package we use. The missing user type:
external_account_authorized_userwas introduced in version v0.12.0, released in September 2023. For more details, refer to the commit: https://cs.opensource.google/go/x/oauth2/+/43b6a7ba1972152df70cd1e5ac7705e981df5f66.Changes
golang.org/x/oauth2package to version:v0.17.0