Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance - Allow a single terraform import command to process multiple resources. #30015

Closed

Conversation

ehud-eshet
Copy link

Currently, each terraform import command reads and parses all *.tf files.
The change allows reading and parsing all *.tf files once.
And then, process all imports using the default amount of parallel threads.

Current code imported 152 resources using 152 import commands in 150 seconds.
Modified code imported same 152 resources using 1 import command in 7.5 seconds.

Currently, each terraform import command reads and parses all *.tf files.
The change allows reading and parsing all *.tf files once.
And then, process all imports using the default amount of parallel threads.

Current code imported 152 resources using 152 import commands in 150 seconds.
Modified code imported same 152 resources using 1 import command in 7.5 seconds.
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 24, 2021

CLA assistant check
All committers have signed the CLA.

@ehud-eshet ehud-eshet changed the title Allow terraform import command to process multiple resources. Performance - Allow a single terraform import command to process multiple resources. Dec 12, 2021
@crw
Copy link
Collaborator

crw commented Jun 15, 2022

Thanks for this submission. Although I cannot commit to having this PR reviewed at this time, we acknowledge your contribution and appreciate it! Thanks again for the submission!

@crw
Copy link
Collaborator

crw commented Jun 15, 2022

Is there an existing issue that describes the problem to be solved by this pull request? Thanks!

@ehud-eshet
Copy link
Author

I believe that issue 22219 complains about same thing.

@madimadi
Copy link

madimadi commented Sep 7, 2022

Merging this PR can be a true performance gain. How can this PR get some priority and looked up by a reviewer to progress?

@crw
Copy link
Collaborator

crw commented Sep 7, 2022

Apologies, we did a triage of this PR in June and I failed to update.

It looks like the same functionality as is being contributed by #22227 - the recommendation at the time was to close this PR and focus on #22227. I am going to leave this one open for a little while longer to gather any feedback on the preceding information; if we mis-identified this as contributing duplicate functionality for example. Thanks for the contribution and the feedback to date!

@crw crw added the waiting-response An issue/pull request is waiting for a response from the community label Sep 7, 2022
@crw crw self-assigned this Sep 7, 2022
@crw
Copy link
Collaborator

crw commented Sep 23, 2022

Going to close this PR in favor of continuing the discussion on #22227. Thanks for your contribution!

@crw crw closed this Sep 23, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2022
@crw crw removed the waiting-response An issue/pull request is waiting for a response from the community label Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants