-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance - Allow a single terraform import command to process multiple resources. #30015
Performance - Allow a single terraform import command to process multiple resources. #30015
Conversation
Currently, each terraform import command reads and parses all *.tf files. The change allows reading and parsing all *.tf files once. And then, process all imports using the default amount of parallel threads. Current code imported 152 resources using 152 import commands in 150 seconds. Modified code imported same 152 resources using 1 import command in 7.5 seconds.
Thanks for this submission. Although I cannot commit to having this PR reviewed at this time, we acknowledge your contribution and appreciate it! Thanks again for the submission! |
Is there an existing issue that describes the problem to be solved by this pull request? Thanks! |
I believe that issue 22219 complains about same thing. |
Merging this PR can be a true performance gain. How can this PR get some priority and looked up by a reviewer to progress? |
Apologies, we did a triage of this PR in June and I failed to update. It looks like the same functionality as is being contributed by #22227 - the recommendation at the time was to close this PR and focus on #22227. I am going to leave this one open for a little while longer to gather any feedback on the preceding information; if we mis-identified this as contributing duplicate functionality for example. Thanks for the contribution and the feedback to date! |
Going to close this PR in favor of continuing the discussion on #22227. Thanks for your contribution! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Currently, each terraform import command reads and parses all *.tf files.
The change allows reading and parsing all *.tf files once.
And then, process all imports using the default amount of parallel threads.
Current code imported 152 resources using 152 import commands in 150 seconds.
Modified code imported same 152 resources using 1 import command in 7.5 seconds.