Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Handle marks on ignore_changes values into v1.0 #29209

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #29193 to be assessed for backporting due to the inclusion of the label 1.0-backport.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


Up until now marks were not considered by ignore_changes, that however
means changes to sensitivity within a configuration cannot be ignored, even
though they are planned as changes.

Rather than separating the marks and tracking their paths, we can easily
update the processIgnoreChanges routine to handle the marked values
directly. Moving the processIgnoreChanges call also cleans up some of
the variable naming, making it more consistent through the body of the
function.

Fixes #29173 in conjunction with hashicorp/hcl#478

@teamterraform teamterraform force-pushed the backport/jbardin/ignore-changes-marks/formerly-new-insect branch 2 times, most recently from fd34acd to 8a8ee41 Compare July 21, 2021 13:06
@teamterraform teamterraform requested a review from jbardin July 21, 2021 13:06
@jbardin jbardin closed this Jul 21, 2021
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants