Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.14 backport of #27318 #27321

Merged
merged 2 commits into from
Dec 17, 2020
Merged

v0.14 backport of #27318 #27321

merged 2 commits into from
Dec 17, 2020

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Dec 17, 2020

Manual backport of #27318

When comparing marks for values during plan and apply, we need to ensure
the order of the marked paths is consistent.
This plan would occasionally show changes when there weren't any due to
the sensitive marks being compared incorrectly.
@jbardin jbardin requested a review from a team December 17, 2020 18:58
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #27321 (d20119f) into v0.14 (c8c0041) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
terraform/eval_apply.go 73.98% <100.00%> (ø)
terraform/eval_diff.go 70.41% <100.00%> (ø)
terraform/marks.go 100.00% <100.00%> (ø)
internal/providercache/dir.go 67.34% <0.00%> (-6.13%) ⬇️
dag/marshal.go 53.42% <0.00%> (-1.37%) ⬇️

@jbardin jbardin merged commit 56370ad into v0.14 Dec 17, 2020
@jbardin jbardin deleted the jbardin/path-marks-v0.14 branch December 17, 2020 19:24
@ghost
Copy link

ghost commented Jan 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants