Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure for_each values wholly known for sets #22597

Merged
merged 6 commits into from
Sep 3, 2019

Conversation

pselle
Copy link
Contributor

@pselle pselle commented Aug 26, 2019

In the case of a set that has some unknown values during the course of a plan (such as a set referencing a variable in an expression), Terraform would panic as it would attempt to convert the unknown value to a string in the evaluation of for_each. Instead, we should check for whollyknown state for for_each in the case of sets, so that we can carry on and the appropriate error will be displayed if a value is indeed unknown, or in the case of the bug, a variable will be evaluated and the plan/apply can continue.

Fixes #22580, #22629

@pselle pselle requested a review from a team August 26, 2019 19:34
@pselle pselle changed the title Ensure for_each values wholly known Ensure for_each values wholly known for sets Aug 28, 2019
@pselle pselle merged commit 555ed96 into hashicorp:master Sep 3, 2019
@pselle pselle deleted the for-each-wholly-known branch September 3, 2019 16:27
@venky999
Copy link

venky999 commented Sep 4, 2019

Hi I am seeing the same issue ...is this going in next release and what would be the terraform version
@pselle @jbardin

@pselle
Copy link
Contributor Author

pselle commented Sep 4, 2019

@venky999 It'll be in the next release, and that will be 0.12.8.

@venky999
Copy link

venky999 commented Sep 4, 2019

@pselle thank you

@ghost
Copy link

ghost commented Oct 4, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Oct 4, 2019
@appilon appilon added sdkv1 [PRs only] Marks changes that may potentially need to be ported to the plugi nSDK and removed sdkv1 [PRs only] Marks changes that may potentially need to be ported to the plugi nSDK labels Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

for_each causes terraform crash when creating null_resource
5 participants