provider/aws: Add resource_aws_volume_attachment #2050

catsby · 2015-05-22T21:32:43Z

Allows you to attach an existing EBS volume to an existing Instance.

Usage:

provider "aws" {
  region="us-west-2"
}

resource "aws_instance" "web" {
  ami = "ami-21f78e11"
  availability_zone = "us-west-2a"
  instance_type = "t1.micro"
  tags {
    Name = "HelloWorld"
  }
}

resource "aws_ebs_volume" "example" {
  availability_zone = "us-west-2a" # must be same as Instance
  size = 5
}

resource "aws_volume_attachment" "ebs_att" {
  device_name = "/dev/sdh"
  volume_id = "${aws_ebs_volume.example.id}"
  instance_id = "${aws_instance.web.id}"
}

Remaining:

docs
acceptance test(s)

catsby · 2015-05-22T22:02:41Z

builtin/providers/aws/resource_aws_ebs_volume_test.go

 			},
 		},
 	})
 }

+func testAccCheckVolumeExists(n string, v *ec2.Volume) resource.TestCheckFunc {


Upgraded this test while I was here, since I needed a testAccCheckVolumeExists method

ghost · 2015-05-26T13:08:41Z

@phinze @catsby

Great!

When do you think to merge this PR? ;) I can't wait for testing it!

catsby · 2015-05-26T14:37:04Z

I plan to review the feedback provided, and maybe make an adjustment or two. I suspect we can merge this afternoon or tomorrow 😄

ghost · 2015-05-26T14:44:26Z

That’s wonderful !

great !

--
Julien Lavergne
Sent with Airmail

On May 26, 2015 at 4:37:17 PM, Clint ([email protected]) wrote:

I plan to review the feedback provided, and maybe make an adjustment or two. I suspect we can merge this afternoon or tomorrow

—
Reply to this email directly or view it on GitHub.

ghost · 2015-05-26T23:01:35Z

Create ebs volume lifecycle is just like any other aws resources. TF just needs to wait for availability of any resources (e.g. aws eip ressource needs an aws instance).

Exist func must mean the ressource has been well created.

catsby · 2015-05-27T22:08:48Z

@phinze refactored – take another look please

ALSO – I think the acc. test leaks a volume, but I haven't had time to crack down on that.

phinze · 2015-05-27T22:22:44Z

builtin/providers/aws/resource_aws_volume_attachment.go

+				vID, iID, awsErr.Message(), awsErr.Code())
+		}
+		return err
+	}


So now that we loop above, there's no eventual consistency here? No need to loop and wait for "attached" or anything?

added polling for attached9329073 , JUST FOR YOU @phinze

phinze · 2015-05-27T22:23:28Z

Clean clean clean! 😻

One question, but if the answer is "nope" this LGTM.

ghost · 2015-05-28T09:10:15Z

no need to wait for attachment; ebs volume needs just to be created above in the platform creation process.

…chment * upstream/master: (21 commits) fix typo fix typo, use awslabs/aws-sdk-go Update CHANGELOG.md More internal links in template documentation. providers/aws: Requires ttl and records attributes if there isn't an ALIAS block. Condense switch fallthroughs into expr lists Fix docs for aws_route53_record params Update CHANGELOG.md provider/aws: Add IAM Server Certificate resource aws_db_instance docs updated per #2070 providers/aws: Adds link to AWS docs about RDS parameters. Downgrade middleman to 3.3.12 as 3.3.13 does not exist providers/aws: Clarifies db_security_group usage. "More more" no more! Indentation issue Export ARN in SQS queue and SNS topic / subscription; updated tests for new AWS SDK errors; updated documentation. Changed Required: false to Optional: true in the SNS topic schema Initial SNS support correct resource name in example added attributes reference section for AWS_EBS_VOLUME ...

catsby · 2015-05-28T15:33:45Z

1f5c038: now with documentation!

catsby · 2015-05-28T15:38:03Z

ALSO – I think the acc. test leaks a volume, but I haven't had time to crack down on that.

I fixed the leak!

mzupan · 2015-05-28T20:45:05Z

just used this and it works great

phinze · 2015-05-28T20:46:31Z

👍 x 💯 LGTM!

ghost · 2015-05-28T20:57:22Z

Thx !

Julien

Le 28 mai 2015 à 22:46, Paul Hinze [email protected] a écrit :

x LGTM!

—
Reply to this email directly or view it on GitHub.

catsby · 2015-05-28T21:24:13Z

Thanks for the validation @mzupan ! Merging...

provider/aws: Add resource_aws_volume_attachment

Pryz · 2015-07-22T22:57:20Z

It seems that the volume is attached after the provisioning of the instance. Is it expected ? If yes, how can we managed the bootstrap of the volume ?

ghost · 2015-07-23T06:18:25Z

It's right and the expected behavior during the instance boot.

Envoyé de mon iPhone

Le 23 juil. 2015 à 00:57, Julien Fabre [email protected] a écrit :

It seems that the volume is attached after the provisioning of the instance. Is it expected ? If yes, how can we managed the bootstrap of the volume ?

—
Reply to this email directly or view it on GitHub.

Pryz · 2015-07-24T00:39:05Z

Thanks. Do you have an example on how to manage the bootstrap of the volume ? (mkfs, etc etc)

phinze · 2015-07-27T14:39:22Z

@Pryz one way would be to add a remote-exec provisioner to the volume attachment itself and give it connection details for the instance, something like this:

resource "aws_volume_attachment" "ebs_att" {
  device_name = "/dev/sdh"
  volume_id = "${aws_ebs_volume.example.id}"
  instance_id = "${aws_instance.web.id}"
  // this will run after the attachment is made
  provisioner "remote-exec" {
    connection {
      host = "${aws_instance.web.public_ip}"
      // ...
    }
    inline = [ "mkfs -t ext4 /dev/sdh" /* ... */ ]
  }
}

ghost · 2015-07-27T17:50:18Z

Cloudinit does the thing very well

--
Julien Lavergne
Sent with Airmail

On July 27, 2015 at 4:39:32 PM, Paul Hinze ([email protected]) wrote:

@Pryz one way would be to add a remote-exec provisioner to the volume attachment itself and give it connection details for the instance, something like this:

resource "aws_volume_attachment" "ebs_att" {
device_name = "/dev/sdh"
volume_id = "${aws_ebs_volume.example.id}"
instance_id = "${aws_instance.web.id}"
// this will run after the attachment is made
provisioner "remote-exec" {
connection {
host = "${aws_instance.web.public_ip}"
// ...
}
inline = [ "mkfs -t ext4 /dev/sdh" /* ... */ ]
}
}
—
Reply to this email directly or view it on GitHub.

Pryz · 2015-09-04T10:05:08Z

The proposition of @phinze is working. I really think that if we can do that directly with a "ebs_block_device" resource things would be more readable and easier to maintain.

Also the @phinze's proposition involve code duplication (about the connection).

@julienlavergne The issue I have with cloudinit is that I have a lot of different instances to maintain. Most of the time the only differences (from Terraform) are about EBS. So having a "generic" cloud-init/user-data and manage the EBS with ebs_block_device would be easier :)

ghost · 2015-09-04T11:00:16Z

I understand this feature.

--
Julien Lavergne
+33670273883
http://julienlavergne.com
Sent with Airmail

On September 4, 2015 at 12:05:26 PM, Julien Fabre ([email protected]) wrote:

The proposition of @phinze is working. I really think that if we can do that directly with a "ebs_block_device" resource things would be more readable and easier to maintain.

Also the @phinze's proposition involve code duplication (about the connection).

@julienlavergne The issue I have with cloudinit is that I have a lot of different instances to maintain. Most of the time the only differences (from Terraform) are about EBS. So having a "generic" cloud-init/user-data and manage the EBS with ebs_block_device would be easier :)

—
Reply to this email directly or view it on GitHub.

ghost · 2020-04-15T02:08:54Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

catsby added 2 commits May 22, 2015 16:30

provider/aws: Add resource_aws_volume_attachment

68587eb

provider/aws: Add accdeptance test for volume attachment

fa44e45

catsby reviewed May 22, 2015
View reviewed changes

radeksimko added enhancement provider/aws labels May 24, 2015

catsby mentioned this pull request May 26, 2015

how to manage AWS_EBS_VOLUME #2043

Closed

catsby added 2 commits May 27, 2015 17:07

provider/aws: Wait for EBS Volume to be available

c523401

refactor volume attachment to not retry attachment

3af25c1

phinze reviewed May 27, 2015
View reviewed changes

catsby added 3 commits May 28, 2015 10:13

refactor to poll for status consistently

9329073

provider/aws: Document Volume Attachment

1f5c038

phinze mentioned this pull request May 28, 2015

ebs_block_volume causing a refresh #2126

Closed

catsby added a commit that referenced this pull request May 28, 2015

Merge pull request #2050 from hashicorp/f-aws-volume-attachment

440537a

provider/aws: Add resource_aws_volume_attachment

catsby merged commit 440537a into master May 28, 2015

catsby deleted the f-aws-volume-attachment branch May 28, 2015 21:24

phinze mentioned this pull request May 29, 2015

AWS - tagging of resources #1296

Closed

7 tasks

phinze mentioned this pull request Jun 16, 2015

provider/aws: attach existing EC2 volumes #1639

Closed

Pryz mentioned this pull request Sep 4, 2015

Re-attaching EBS volumes to new EC2 instances... #2740

Closed

vasiliyb mentioned this pull request Apr 10, 2016

EBS: InvalidZone.NotFound #6110

Closed

JJediny mentioned this pull request Jul 25, 2017

Volume swapping with Auto-scaling Group GSA/datagov-infrastructure#4

Open

ghost locked and limited conversation to collaborators Apr 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provider/aws: Add resource_aws_volume_attachment #2050

provider/aws: Add resource_aws_volume_attachment #2050

catsby commented May 22, 2015 •

edited by danawillow

Loading

catsby May 22, 2015

phinze May 22, 2015

ghost commented May 26, 2015

catsby commented May 26, 2015

ghost commented May 26, 2015

ghost commented May 26, 2015

catsby commented May 27, 2015

phinze May 27, 2015

catsby May 28, 2015

phinze commented May 27, 2015

ghost commented May 28, 2015

catsby commented May 28, 2015

catsby commented May 28, 2015

mzupan commented May 28, 2015

phinze commented May 28, 2015

ghost commented May 28, 2015

catsby commented May 28, 2015

Pryz commented Jul 22, 2015

ghost commented Jul 23, 2015

Pryz commented Jul 24, 2015

phinze commented Jul 27, 2015

ghost commented Jul 27, 2015

Pryz commented Sep 4, 2015

ghost commented Sep 4, 2015

ghost commented Apr 15, 2020

provider/aws: Add resource_aws_volume_attachment #2050

provider/aws: Add resource_aws_volume_attachment #2050

Conversation

catsby commented May 22, 2015 • edited by danawillow Loading

catsby May 22, 2015

Choose a reason for hiding this comment

phinze May 22, 2015

Choose a reason for hiding this comment

ghost commented May 26, 2015

catsby commented May 26, 2015

ghost commented May 26, 2015

ghost commented May 26, 2015

catsby commented May 27, 2015

phinze May 27, 2015

Choose a reason for hiding this comment

catsby May 28, 2015

Choose a reason for hiding this comment

phinze commented May 27, 2015

ghost commented May 28, 2015

catsby commented May 28, 2015

catsby commented May 28, 2015

mzupan commented May 28, 2015

phinze commented May 28, 2015

ghost commented May 28, 2015

catsby commented May 28, 2015

Pryz commented Jul 22, 2015

ghost commented Jul 23, 2015

Pryz commented Jul 24, 2015

phinze commented Jul 27, 2015

ghost commented Jul 27, 2015

Pryz commented Sep 4, 2015

ghost commented Sep 4, 2015

ghost commented Apr 15, 2020

catsby commented May 22, 2015 •

edited by danawillow

Loading