Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend/s3: Configure AWS Client MaxRetries and provide enhanced S3 NoSuchBucket error message #20338

Closed
wants to merge 1 commit into from
Closed

backend/s3: Configure AWS Client MaxRetries and provide enhanced S3 NoSuchBucket error message #20338

wants to merge 1 commit into from

Commits on Feb 14, 2019

  1. backend/s3: Configure AWS Client MaxRetries and provide enhanced S3 N… 

    …oSuchBucket error message

The AWS Go SDK automatically provides a default request retryer with exponential backoff that is invoked via setting `MaxRetries` or leaving it `nil` will default to 3. The terraform-aws-provider `config.Client()` sets `MaxRetries` to 0 unless explicitly configured above 0. Previously, we were not overriding this behavior by setting the configuration and therefore not invoking the default request retryer.

The default retryer already handles HTTP error codes above 500, including S3's InternalError response, so the extraneous handling can be removed. This will also start automatically retrying many additional cases, such as temporary networking issues or other retryable AWS service responses.

Changes:
* s3/backend: Add `max_retries` argument
* s3/backend: Enhance S3 NoSuchBucket error to include additional information
    @bflad
    bflad committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    ca57a3b View commit details
    Browse the repository at this point in the history