Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vpc dns attribute support #172

Merged
merged 1 commit into from
Aug 20, 2014

Conversation

deoxxa
Copy link
Contributor

@deoxxa deoxxa commented Aug 9, 2014

This is dependent on mitchellh/goamz#76 but should be relatively straightforward. As with the other PR, I'm not sure quite how to go about adding tests for it, so any advice would be greatly appreciated.

@deoxxa
Copy link
Contributor Author

deoxxa commented Aug 9, 2014

/cc #28

@deoxxa deoxxa mentioned this pull request Aug 9, 2014
@pearkes
Copy link
Contributor

pearkes commented Aug 20, 2014

Awesome, thanks! I'm going to merge this and add tests, I'll cc you on that.

pearkes added a commit that referenced this pull request Aug 20, 2014
@pearkes pearkes merged commit 33a7d32 into hashicorp:master Aug 20, 2014
@ghost ghost locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants