Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: avoid diff mismatch on NewRemoved fields during -/+ #1515

Merged
merged 1 commit into from
Apr 14, 2015
Merged

core: avoid diff mismatch on NewRemoved fields during -/+ #1515

merged 1 commit into from
Apr 14, 2015

Commits on Apr 14, 2015

  1. core: avoid diff mismatch on NewRemoved fields during -/+ 

    fixes #1508

In a DESTROY/CREATE scenario, the plan diff will be run against the
state of the old instance, while the apply diff will be run against an
empty state (because the state is cleared when the destroy node does its
thing.)

For complex attributes, this can result in keys that seem to disappear
between the two diffs, when in reality everything is working just fine.

Same() needs to take into account this scenario by analyzing NewRemoved
and treating as "Same" a diff that does indeed have that key removed.
    @phinze
    phinze committed Apr 14, 2015
    Configuration menu
    Copy the full SHA
    64f0897 View commit details
    Browse the repository at this point in the history