-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Convert AWS ASG to upstream aws-sdk-go #1513
Conversation
@@ -30,6 +31,7 @@ type AWSClient struct { | |||
ec2conn *ec2.EC2 | |||
elbconn *elb.ELB | |||
autoscalingconn *autoscaling.AutoScaling | |||
asgconn *awsASG.AutoScaling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need a separate connection for the meantime, until Launch Config. is converted. LC is a non-trivial size resource so I didn't bundle it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 good call
@@ -146,9 +146,9 @@ func autoscalingTagsToMap(ts []autoscaling.Tag) map[string]interface{} { | |||
} | |||
|
|||
// autoscalingTagDescriptionsToMap turns the list of tags into a map. | |||
func autoscalingTagDescriptionsToMap(ts []autoscaling.TagDescription) map[string]map[string]interface{} { | |||
func autoscalingTagDescriptionsToMap(ts *[]*autoscaling.TagDescription) map[string]map[string]interface{} { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*[]*
tee hee
LGTM |
bd333b7
to
210b380
Compare
provider/aws: Convert AWS ASG to upstream aws-sdk-go
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Converts AWS ASG resource and companion tag library.