Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Convert AWS RDS to use upstream aws-sdk-go #1510

Merged
merged 5 commits into from
Apr 15, 2015

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Apr 13, 2015

Converts RDS to use github.com/awslabs/aws-sdk-go

@catsby catsby force-pushed the f-aws-upstream-rds-instance branch from a6ea833 to 470379e Compare April 15, 2015 19:36
@catsby
Copy link
Contributor Author

catsby commented Apr 15, 2015

rebased on master, should be 👍 for review

"github.com/hashicorp/aws-sdk-go/gen/iam"
"github.com/hashicorp/aws-sdk-go/gen/rds"
"github.com/awslabs/aws-sdk-go/aws"
"github.com/awslabs/aws-sdk-go/service/IAM"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IAM is really capitalized?

@phinze
Copy link
Contributor

phinze commented Apr 15, 2015

Code LGTM - there's a buncha whitespace diff that seems like it's from some weird tab/spaces munging that happened.

@catsby
Copy link
Contributor Author

catsby commented Apr 15, 2015

Fixed the whitespace noise with df45b2c

catsby added a commit that referenced this pull request Apr 15, 2015
provider/aws: Convert AWS RDS to use upstream aws-sdk-go
@catsby catsby merged commit 334b157 into master Apr 15, 2015
@catsby catsby deleted the f-aws-upstream-rds-instance branch April 15, 2015 20:23
@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants