provider/aws: Add tag support to ELB #1289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Tag support to Elastic Load Balancers, at the cost of a mostly duplicated
builtin/providers/aws/tags.go
file 😦Unfortunately,
aws-sdk-go
has aTag
struct declaration for each resource, instead of a common one, so we'll need versions oftags.go
for each, unless we can manage to maketags.go
more generic with our ownTag
struct, and cast as needed, but that may be more work than worth it.