Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: expose Route 53 zone nameservers #1214

Closed
wants to merge 1 commit into from

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Mar 16, 2015

🚧
This PR attempts to expose the NS elements of Route 53 zone. Refs #462

@@ -87,6 +94,11 @@ func resourceAwsRoute53ZoneRead(d *schema.ResourceData, meta interface{}) error
return err
}

if rs.DelegationSet != nil {
d.Set("nameservers", rs.DelegationSet.NameServers)
log.Printf("\t@@@DEBUG: %#v:\t%#v\n", rs.DelegationSet.NameServers)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug line!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧

@mitchellh
Copy link
Contributor

LGTM. It might be nice to add to the acceptance tests as well.

@catsby
Copy link
Contributor Author

catsby commented Mar 16, 2015

Example config for proof of concept:

provider "aws" {
   region = "us-west-2"
}

resource "aws_route53_zone" "main" {
    name = "notexample.com"
}

resource "aws_route53_record" "default" {
    zone_id = "${aws_route53_zone.main.zone_id}"
    name = "www.notexample.com"
    type = "A"
    ttl = "30"
    records = ["127.0.0.1"]
}

resource "aws_instance" "default" {
  ami = "ami-9fc29baf"
  instance_type = "t1.micro"
  tags {
    Name = "testing-user-data-things"
    TestData = "${aws_route53_zone.main.nameservers.1}"
  }
}

I believe this is blocked by #1215 though

@phinze
Copy link
Contributor

phinze commented Apr 6, 2015

This seems AOK - just needs an acceptance test line added to cover us for this attribute.

@catsby
Copy link
Contributor Author

catsby commented Apr 6, 2015

I'll revisit this when #1215 is resolved

@catsby
Copy link
Contributor Author

catsby commented Apr 14, 2015

close in favor of #1525

@catsby catsby closed this Apr 14, 2015
@mitchellh mitchellh deleted the f-route53-expose-ns-attributes branch June 26, 2015 22:50
@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants