-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: expose Route 53 zone nameservers #1214
Conversation
@@ -87,6 +94,11 @@ func resourceAwsRoute53ZoneRead(d *schema.ResourceData, meta interface{}) error | |||
return err | |||
} | |||
|
|||
if rs.DelegationSet != nil { | |||
d.Set("nameservers", rs.DelegationSet.NameServers) | |||
log.Printf("\t@@@DEBUG: %#v:\t%#v\n", rs.DelegationSet.NameServers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug line!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧
LGTM. It might be nice to add to the acceptance tests as well. |
Example config for proof of concept:
I believe this is blocked by #1215 though |
This seems AOK - just needs an acceptance test line added to cover us for this attribute. |
I'll revisit this when #1215 is resolved |
close in favor of #1525 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
🚧
This PR attempts to expose the NS elements of Route 53 zone. Refs #462