Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Allow aws_instances to be resized rather than forcing a new instance #11998

Merged
merged 1 commit into from
Feb 16, 2017
Merged

provider/aws: Allow aws_instances to be resized rather than forcing a new instance #11998

merged 1 commit into from
Feb 16, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Feb 16, 2017 •
edited
Loading

Fixes: #9157

=== RUN   TestAccAWSInstance_blockDevices
--- PASS: TestAccAWSInstance_blockDevices (103.44s)
=== RUN   TestAccAWSInstance_rootInstanceStore
--- PASS: TestAccAWSInstance_rootInstanceStore (89.57s)
=== RUN   TestAccAWSInstance_sourceDestCheck
--- PASS: TestAccAWSInstance_sourceDestCheck (215.78s)
=== RUN   TestAccAWSInstance_disableApiTermination
--- PASS: TestAccAWSInstance_disableApiTermination (200.73s)
=== RUN   TestAccAWSInstance_vpc
--- PASS: TestAccAWSInstance_vpc (120.63s)
=== RUN   TestAccAWSInstance_multipleRegions
--- PASS: TestAccAWSInstance_multipleRegions (139.59s)
=== RUN   TestAccAWSInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (144.18s)
=== RUN   TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (167.91s)
=== RUN   TestAccAWSInstance_tags
--- PASS: TestAccAWSInstance_tags (130.65s)
=== RUN   TestAccAWSInstance_privateIP
--- PASS: TestAccAWSInstance_privateIP (252.07s)
=== RUN   TestAccAWSInstance_associatePublicIPAndPrivateIP
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (250.28s)
=== RUN   TestAccAWSInstance_keyPairCheck
--- PASS: TestAccAWSInstance_keyPairCheck (87.52s)
=== RUN   TestAccAWSInstance_rootBlockDeviceMismatch
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (113.74s)
=== RUN   TestAccAWSInstance_forceNewAndTagsDrift
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (233.94s)
=== RUN   TestAccAWSInstance_changeInstanceType
--- PASS: TestAccAWSInstance_changeInstanceType (152.62s)

@stack72 stack72 changed the title [WIP] provider/aws: Allow aws_instances to be resized rather than forcing a new instance provider/aws: Allow aws_instances to be resized rather than forcing a new instance Feb 16, 2017
@stack72
provider/aws: Allow aws_instances to be resized rather than forcing a
494398d 
new instance

Fixes: #9157

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSInstance_changeInstanceType'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/16 15:13:21 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSInstance_changeInstanceType -timeout 120m
=== RUN   TestAccAWSInstance_changeInstanceType
--- PASS: TestAccAWSInstance_changeInstanceType (303.85s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	303.876s
```
grubernaut
grubernaut approved these changes Feb 16, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🇱🇹

@stack72 stack72 merged commit 546b424 into master Feb 16, 2017
@stack72 stack72 deleted the f-aws-instance-resize branch February 16, 2017 14:43
stack72 added a commit that referenced this pull request Feb 16, 2017
@stack72
provider/aws: Allow aws_instances to be resized rather than forcing a (…
e59d5f7 
…#11998)

new instance

Fixes: #9157

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSInstance_changeInstanceType'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/16 15:13:21 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSInstance_changeInstanceType -timeout 120m
=== RUN   TestAccAWSInstance_changeInstanceType
--- PASS: TestAccAWSInstance_changeInstanceType (303.85s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	303.876s
```
@stack72 stack72 mentioned this pull request Feb 23, 2017
Closed
@philstevenson
Copy link

What happens when you are resizing an ebs optimised instance to a non-ebs optimised instance, like an m4.large to an t2.large?

@spkane spkane mentioned this pull request Mar 14, 2017
Closed
@artburkart artburkart mentioned this pull request Mar 20, 2017
Closed
This was referenced Apr 2, 2017
Closed
Closed
@hashibot hashibot mentioned this pull request Jun 13, 2017
Closed
@paddycarver paddycarver mentioned this pull request Sep 11, 2017
Closed
@paddycarver paddycarver mentioned this pull request Nov 29, 2017
Closed
@danawillow danawillow mentioned this pull request Jan 24, 2018
Merged
@tomelliff tomelliff mentioned this pull request Jun 21, 2018
Closed
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grubernaut grubernaut grubernaut approved these changes

Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Downgrading ec2 instance type from t2.small to t2.micro "forces new resource"
3 participants
@stack72 @philstevenson @grubernaut