Add the ability to manage tags on ASGs #1076
Conversation
|
|
||
| "propagate": &schema.Schema{ | ||
| Type: schema.TypeBool, | ||
| Required: true, |
There was a problem hiding this comment.
The ASG API reference lists propagate as optional, is there a reason to mark this as required here?
There was a problem hiding this comment.
I wasn't sure what default people would like (I assume not propagated), so I made it mandatory so people had to choose.
I'd be happy to make it optional / default to false if that's what people think is best.
|
Looks pretty solid from here. |
bobtfish
force-pushed
the
add_tags_to_asgs
branch
from
7886a75
to
e80a844
Compare
This reverts commit e80a844.
|
Close in favour of PR #1080 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Fixes issue #932
I've had a bash at this - code appears to work, but my Go isn't all that great, so please feel free to tear it apart ;)