Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_network_acl_rule: Transient error on creation #4721

Closed
vancluever opened this issue Jan 18, 2016 · 3 comments · Fixed by #4734
Closed

aws_network_acl_rule: Transient error on creation #4721

vancluever opened this issue Jan 18, 2016 · 3 comments · Fixed by #4734
Labels
bug provider/aws

Comments

@vancluever
Copy link
Contributor

Guys,

Been getting errors like these in my VPC modules:

Error applying plan:

1 error(s) occurred:

* aws_network_acl_rule.network_acl_rule.2: Expected to find one Network ACL, got: []*ec2.NetworkAcl(nil)

Re-running the apply succeeds, without any extra resources created. I'm guessing maybe we are not waiting for resource creation properly?
jen20 added a commit that referenced this issue Jan 19, 2016
@jen20
provider/aws: Wait for NACL rule to be visible
7620381 
Fixes #4721. It seems there may be some eventual consistency in the API
for network ACLs. This fix doesn't use resource.WaitForState() as there
the NACL is not something that can be looked up by ID and has a
property which determines if it is present.

Instead we reuse the findNetworkAclRule function which the Read function
exhibiting the problem uses, and retry over a 3 minute period, returning
an error message informing the user that running `terraform apply` again
will likely allow them to continue.
@jen20 jen20 mentioned this issue Jan 19, 2016
Merged
@jen20
Copy link
Contributor

jen20 commented Jan 19, 2016

Hi @vancluever, I've put forward a potential fix in #4734 for this. Thanks for reporting!

@vancluever
Copy link
Contributor Author

Thanks @jen20!

bigkraig pushed a commit to bigkraig/terraform that referenced this issue Mar 1, 2016
@jen20 @bigkraig
provider/aws: Wait for NACL rule to be visible
c3f4e34 
Fixes hashicorp#4721. It seems there may be some eventual consistency in the API
for network ACLs. This fix doesn't use resource.WaitForState() as there
the NACL is not something that can be looked up by ID and has a
property which determines if it is present.

Instead we reuse the findNetworkAclRule function which the Read function
exhibiting the problem uses, and retry over a 3 minute period, returning
an error message informing the user that running `terraform apply` again
will likely allow them to continue.
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

provider/aws: Wait for NACL rule to be visible hashicorp/terraform
2 participants
@jen20 @vancluever