Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google_compute_project_metadata: sshKeys shows up in response; generates diff #4504

Closed
phinze opened this issue Jan 5, 2016 · 3 comments
Closed

google_compute_project_metadata: sshKeys shows up in response; generates diff #4504

phinze opened this issue Jan 5, 2016 · 3 comments
Labels
bug provider/google-cloud

Comments

@phinze
Copy link
Contributor

phinze commented Jan 5, 2016

We're getting this acceptance test failure on master:

https://travis-ci.org/hashicorp/terraform/jobs/100228177#L631

--- FAIL: TestAccComputeProjectMetadata_basic (27.35s)
    testing.go:144: Step 0 error: After applying this step, the plan was not empty:

        DIFF:

        UPDATE: google_compute_project_metadata.fizzbuzz
          metadata.#:       "3" => "2"
          metadata.sshKeys: "" => ""

        STATE:

        google_compute_project_metadata.fizzbuzz:
          ID = common_metadata
          metadata.# = 3
          metadata.banana = orange
          metadata.sofa = darwinism
          metadata.sshKeys =

Not sure what the best action is to take here - should we special case sshKeys and ignore that field for project metadata purposes?

Pinging @lwander to find out!
phinze added a commit that referenced this issue Jan 5, 2016
@phinze
provider/google: skip failing test so build can go green
c57aae3 
Failure reason filed as
#4504, fixing PR can unskip
test as it resolve the underlying issue.
phinze added a commit that referenced this issue Jan 5, 2016
@phinze
provider/google: skip remainder of metadata tests
5c6304e 
Any of the tests can fail due to
#4504
@lwander
Copy link
Contributor

lwander commented Jan 5, 2016

Looking into this now!

@lwander lwander mentioned this issue Jan 5, 2016
Merged
@phinze
Copy link
Contributor Author

phinze commented Jan 5, 2016

Fixed in #4512, thanks again @lwander!

@phinze phinze closed this as completed Jan 5, 2016
grubernaut pushed a commit to hashicorp/terraform-provider-google that referenced this issue Jun 6, 2017
@phinze
provider/google: skip failing test so build can go green
8e31314 
Failure reason filed as
hashicorp/terraform#4504, fixing PR can unskip
test as it resolve the underlying issue.
grubernaut pushed a commit to hashicorp/terraform-provider-google that referenced this issue Jun 6, 2017
@phinze
provider/google: skip remainder of metadata tests
e6186f3 
Any of the tests can fail due to
hashicorp/terraform#4504
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug provider/google-cloud
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phinze @lwander