terraform destroy -target=module.xxx #4462
Comments
|
@AVVS Thanks of reporting this. I will investigate this and try to reproduce - it certainly sounds like a core bug to me. |
|
We saw some similar problems when we tried to destroy a single instance.
If we fuck up the machine id, it tries to destroy the whole xxx module!? I dont know if this is correlating or not, but it is definitly a bad behavior! |
phinze
added a commit
that referenced
this issue
Jan 19, 2016
Instead of trying to skip non-targeted orphans as they are added to the graph in OrphanTransformer, remove knowledge of targeting from OrphanTransformer and instead make the orphan resource nodes properly addressable. That allows us to use existing logic in TargetTransformer to filter out the nodes appropriately. This does require adding TargetTransformer to the list of transforms that run during DynamicExpand so that targeting can be applied to nodes with expanded counts. Fixes #4515 Fixes #2538 Fixes #4462
phinze
added a commit
that referenced
this issue
Jan 19, 2016
Instead of trying to skip non-targeted orphans as they are added to the graph in OrphanTransformer, remove knowledge of targeting from OrphanTransformer and instead make the orphan resource nodes properly addressable. That allows us to use existing logic in TargetTransformer to filter out the nodes appropriately. This does require adding TargetTransformer to the list of transforms that run during DynamicExpand so that targeting can be applied to nodes with expanded counts. Fixes #4515 Fixes #2538 Fixes #4462
bigkraig
pushed a commit
to bigkraig/terraform
that referenced
this issue
Mar 1, 2016
Instead of trying to skip non-targeted orphans as they are added to the graph in OrphanTransformer, remove knowledge of targeting from OrphanTransformer and instead make the orphan resource nodes properly addressable. That allows us to use existing logic in TargetTransformer to filter out the nodes appropriately. This does require adding TargetTransformer to the list of transforms that run during DynamicExpand so that targeting can be applied to nodes with expanded counts. Fixes hashicorp#4515 Fixes hashicorp#2538 Fixes hashicorp#4462
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
it doesn't destroy instances that are referenced in the nested modules, ie:
module.xxx:
module "chef-machine" {
}
some_ipaddress_resource ...
module.chef-machine:
some_instance_resource
When doing
terraform destroy -target=module.xxxit will destroysome_ipaddress_resourceonly,leaving module.chef-machine resources up
When doing
terraform destroy -target=module.xxx.module.chef-machineit will destroy chef-machine resources, leaving other module.xxx resources up, which is correct behaviourThe text was updated successfully, but these errors were encountered: