Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Allow changing private IPs for ENIs #4307

Merged
merged 1 commit into from
Dec 16, 2015

Conversation

justnom
Copy link
Contributor

@justnom justnom commented Dec 14, 2015

Fixing #4253.

@radeksimko radeksimko changed the title Fixes #4253 provider/aws: Allow changing private IPs for ENIs Dec 15, 2015
@@ -200,6 +199,14 @@ func resourceAwsNetworkInterfaceDetach(oa *schema.Set, meta interface{}, eniId s
return nil
}

func convertToAwsStringSlice(s []interface{}) []*string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a method just like this! It's expandStringList:

I'll go ahead and merge as-is and then replace myself, so you don't need to be troubled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh cheers! I'll keep that in mind for next time 👍

@catsby
Copy link
Contributor

catsby commented Dec 16, 2015

Thanks! This looks good

catsby added a commit that referenced this pull request Dec 16, 2015
provider/aws: Allow changing private IPs for ENIs
@catsby catsby merged commit fb2735e into hashicorp:master Dec 16, 2015
@justnom justnom deleted the b-private-ips-eni branch December 16, 2015 20:40
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants