Expose Route53 zone nameservers for parent zone NS record

[lamdor]

No description provided.

[knuckolls]

👍 lgtm

[catsby]

d.Set can return an error, can you check to make sure it's nil? We've seen bugs go by silently by not checking for errors when setting a non-primitive type.

if err := d.Set("delegation_set_name_servers", zone.DelegationSet.NameServers); err != nil{

or similar, like in https://github.com/hashicorp/terraform/blob/master/builtin/providers/aws/resource_aws_route53_record.go#L199

[mitchellh]

We should sort this. Or, use a set.

[pmoust]

This closes #462, another WIP was #1214

[catsby]

I just closed #1525

[lamdor]

All changes have been made. cc @catsby @mitchellh @pmoust

--- PASS: TestAccRoute53Zone (135.52s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    135.539s

[lamdor]

hold off on this. there's one more change i think i need to make.

[lamdor]

The problem I'm running into is dealing with the computed attribute. I want to modify another record with the name servers (basically an NS record on the "parent" zone). But I can't for the life of me figure out how to get it to resolve right.

So I have this configuration (simplified a bit):

variable "parent_route53_zone_id" { }

provider "aws" {
  region = "us-east-1"
}

resource "aws_route53_zone" "foo" {
  name = "foo.bar.com"
}

resource "aws_route53_record" "ns_in_bar" {
  zone_id = "${var.parent_route53_zone_id}"
  name = "bar.com"
  type = "NS"
  ttl = "30"
  records = [
    "${aws_route53_zone.foo.name_servers.*}"
  ]
}

I've also tried it with just an echo in a null_resource like:

resource "null_resource" "echo_ns" {
  provisioner "local-exec" {
    command = "echo ${join("--", aws_route53_zone.bar.name_servers.*)}"
  }
}

But I keep getting: * Resource 'aws_route53_zone.bar' does not have attribute 'name_servers.*' for variable 'aws_route53_zone.bar.name_servers.*

I then tried to see if I gave the name_servers more structure if they'd work. I changed the schema to:

            "name_servers": &schema.Schema{
                Type:     schema.TypeSet,
                Computed: true,
                Elem: &schema.Resource{
                    Schema: map[string]*schema.Schema{
                        "name": &schema.Schema{
                            Type: schema.TypeString,
                        },
                    },
                },
                Set: func(v interface{}) int {
                    m := v.(map[string]interface{})
                    return hashcode.String(m["name"].(string))
                },
            },

and set the resource data correctly with map's instead.

I then changed the configuration to:

variable "parent_route53_zone_id" { }

provider "aws" {
  region = "us-east-1"
}

resource "aws_route53_zone" "foo" {
  name = "foo.bar.com"
}

resource "aws_route53_record" "ns_in_bar" {
  zone_id = "${var.parent_route53_zone_id}"
  name = "bar.com"
  type = "NS"
  ttl = "30"
  records = [
    "${aws_route53_zone.foo.name_servers.*.name}"
  ]
}

Still no dice: * Resource 'aws_route53_zone.bar' does not have attribute 'name_servers.*.name' for variable 'aws_route53_zone.bar.name_servers.*.name for both the ns record and the null_resource.

Any ideas on how I can make this work?

[mitchellh]

LGTM. @rubbish That's not currently possible, though I think this should work: ${join("--", aws_route53_zone.foo.nameservers)}

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.