fix tests

hashicorp · Dec 17, 2024 · aea2a5a · aea2a5a
1 parent f0bfb61
commit aea2a5a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 15 deletions.
diff --git a/internal/command/test_test.go b/internal/command/test_test.go
@@ -219,13 +219,19 @@ func TestTest_Runs(t *testing.T) {
 			code:        0,
 		},
 		"mocking": {
-			expectedOut: []string{"6 passed, 0 failed."},
+			expectedOut: []string{"7 passed, 0 failed."},
 			code:        0,
 		},
 		"mocking-invalid": {
 			expectedErr: []string{"Invalid outputs attribute"},
 			initCode:    1,
 		},
+		"mocking-error": {
+			expectedErr: []string{"Unknown condition value",
+				"test_resource.primary[0].id",
+			},
+			code: 1,
+		},
 		"dangling_data_block": {
 			expectedOut: []string{"2 passed, 0 failed."},
 			code:        0,

diff --git a/internal/command/testdata/test/mocking-error/tests/plan_mocked_overridden.tftest.hcl b/internal/command/testdata/test/mocking-error/tests/plan_mocked_overridden.tftest.hcl
@@ -26,7 +26,7 @@ run "test" {
   command = plan
 
   assert {
-    condition = test_resource.primary[0].id != "bbbb"
+    condition = test_resource.primary[0].id == "bbbb"
     error_message = "plan should not have the overridden value"
   }
 

diff --git a/internal/terraform/node_resource_abstract_instance.go b/internal/terraform/node_resource_abstract_instance.go
@@ -1250,19 +1250,6 @@ func (n *NodeAbstractResourceInstance) plan(
 	return plan, state, deferred, keyData, diags
 }
 
-// func getMockedData(override *configs.Override, isPlan bool) *mocking.MockedData {
-// 	if override == nil {
-// 		return nil
-// 	}
-// 	return &mocking.MockedData{
-// 		Value: override.Values,
-// 		Range: override.Range,
-// 		// Apply never ignores computed values. This attribute only matters
-// 		// when we are planning.
-// 		ComputedAsUnknown: override.IgnoreValues && isPlan,
-// 	}
-// }
-
 func (n *NodeAbstractResource) processIgnoreChanges(prior, config cty.Value, schema *configschema.Block) (cty.Value, tfdiags.Diagnostics) {
 	// ignore_changes only applies when an object already exists, since we
 	// can't ignore changes to a thing we've not created yet.