Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: Introduce BuiltinReferences(modPath) #93

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Conversation

radeksimko
Copy link
Member

This is to help with decoupling in hashicorp/terraform-ls#719

This logic is pretty much copy-paste of what we have in the current LS codebase:

https://github.com/hashicorp/terraform-ls/blob/main/internal/terraform/module/builtin_references.go

@radeksimko radeksimko requested a review from a team January 31, 2022 12:14
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have loved some code comments explaining what the method does, but this LGTM otherwise

Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radeksimko radeksimko merged commit 30b46a8 into main Feb 3, 2022
@radeksimko radeksimko deleted the f-builtin-refs branch February 3, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants