Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow local references in depends_on #292

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Allow local references in depends_on #292

merged 3 commits into from
Nov 3, 2023

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Nov 1, 2023 •
edited
Loading

As follow-up to #290, this PR allows local references in depends_on.

UX Before

CleanShot 2023-11-03 at 14 46 27@2x

UX After

CleanShot 2023-11-03 at 14 47 11@2x

@dbanck dbanck added the bug Something isn't working label Nov 1, 2023
@dbanck dbanck self-assigned this Nov 1, 2023
@dbanck dbanck mentioned this pull request Nov 3, 2023
Merged
@dbanck dbanck force-pushed the b-add-locals-to-depends_on branch 2 times, most recently from 7225ec7 to 258d3f8 Compare November 3, 2023 13:40
@dbanck dbanck marked this pull request as ready for review November 3, 2023 13:47
@dbanck dbanck requested a review from a team as a code owner November 3, 2023 13:47
radeksimko
radeksimko approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :shipit:

@dbanck dbanck merged commit 8af5a07 into main Nov 3, 2023
5 checks passed
@dbanck dbanck deleted the b-add-locals-to-depends_on branch November 3, 2023 13:52
@radeksimko radeksimko mentioned this pull request Nov 3, 2023
Merged
@BrewTestBot BrewTestBot mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees

@dbanck dbanck

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbanck @radeksimko