Sort vault_policy_document allowed/denied parameters by key name

[martinssipenko]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Description

When running terraform plan, terraform produces false positive changes because Go iterates maps in randomized order. This change adds sorting by keys name values to overcome randomness.

Release note for CHANGELOG:

Sort `vault_policy_document` data source allowed/denied parameters by key name.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestDataSourcePolicyDocument'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestDataSourcePolicyDocument -timeout 120m
?   	github.com/terraform-providers/terraform-provider-vault	[no test files]
?   	github.com/terraform-providers/terraform-provider-vault/cmd/coverage	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/util	(cached) [no tests to run]
=== RUN   TestDataSourcePolicyDocument
--- PASS: TestDataSourcePolicyDocument (0.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/vault	(cached)
...

[tyrannosaurus-becks]

Nice! Thank you for fixing this!