Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthly maintenance #591

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Monthly maintenance #591

merged 2 commits into from
Nov 4, 2019

Conversation

tyrannosaurus-becks
Copy link
Contributor

This PR makes the following changes:

  • Simplifies the path used for the CircleCI builds. I'd over-complicated it earlier by attempting to directly use the $GOPATH provided by Circle, which is actually multiple directories, only some of which we have write access to. I later realized we could just hard-code the one with write access and use it all the way through to improve the code's readability.
  • Updates the openapi.json doc against present Vault master. It's a helpful and rather accurate report, not a perfectly accurate report, so I use bleeding edge data.
  • Begins the deprecation process on a dupe resource the report uncovered.

@tyrannosaurus-becks tyrannosaurus-becks changed the title Monthly maintenance WIP: Monthly maintenance Oct 31, 2019
@tyrannosaurus-becks tyrannosaurus-becks changed the title WIP: Monthly maintenance Monthly maintenance Oct 31, 2019
@tyrannosaurus-becks tyrannosaurus-becks merged commit d56f0a5 into master Nov 4, 2019
@tyrannosaurus-becks tyrannosaurus-becks deleted the openapi-and-circleci branch November 4, 2019 18:13
@@ -11,6 +11,7 @@ import (

func identityOidcKeyAllowedClientId() *schema.Resource {
return &schema.Resource{
DeprecationMessage: "This resource is a less-featured dupe and is being deprecated in favor of the `vault_identity_oidc_key` resource. Please update your configuration.",
Copy link
Contributor

@lawliet89 lawliet89 Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tyrannosaurus-becks, this resource isn't really a duplicate per se. This is meant to allow the user to specify the alllowed_client_ids of an OIDC key in a decoupled manner.

We discussed this in #488 with @kalafut

dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants