Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for configuring the Transit cache #548

Merged
merged 3 commits into from
Oct 2, 2019
Merged

Add support for configuring the Transit cache #548

merged 3 commits into from
Oct 2, 2019

Conversation

kalafut
Copy link
Contributor

@kalafut kalafut commented Sep 24, 2019

No description provided.

catsby
catsby suggested changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments/questions I'd like to hear back on, nothing major

website/docs/r/transit_secret_backend_cache_config.html.md Show resolved Hide resolved
vault/resource_transit_cache_config.go Outdated Show resolved Hide resolved
vault/resource_transit_cache_config.go Outdated Show resolved Hide resolved
vault/resource_transit_cache_config.go Show resolved Hide resolved
@kalafut
Copy link
Contributor Author

kalafut commented Oct 2, 2019

@catsby Added the StateFunc like we discussed.

catsby
catsby approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@kalafut kalafut merged commit 3008895 into master Oct 2, 2019
@kalafut kalafut deleted the transit-cache-config branch October 2, 2019 16:10
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Add support for configuring the Transit cache (hashicorp#548)
d87160f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malnick malnick malnick left review comments

@catsby catsby catsby approved these changes

@tyrannosaurus-becks tyrannosaurus-becks Awaiting requested review from tyrannosaurus-becks

Assignees

@catsby catsby

Labels
documentation size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalafut @catsby @malnick