Fix wrong response data from gcp_auth_backend_role read request

[Phylu]

As of hashicorp/vault-plugin-auth-gcp@438b86d, the role_type field has been changed to type.

This pull request should resolve #228.

[Phylu]

Tests seem to fail as the vault version used in the tests (0.11.1) is before the change which renamed the field in vault.

[OperationalDev]

Tests pass with Vault v1.0.0-beta2.

[tyrannosaurus-becks]

@Phylu thanks for working on this! Should be good to after we handle compatibility issues.

[tyrannosaurus-becks]

Saw you pushed some code! I noticed there's a test failure that looks related:

--- FAIL: TestGCPAuthBackendRole_gce (0.06s)
    testing.go:434: Step 0 error: Check failed: Expected type (type in state) of "auth/tf-test-gcp-backend-3800239246745760615/role/tf-test-gcp-role-294652960337314985" to be "gce", got %!q(<nil>)

[Phylu]

The latest changes fix the failing acceptance tests. I had to revert the change that I made to the test where I renamed the expected attribute as well. This might be needed to change, later when the tests run with a newer version of vault.

[tyrannosaurus-becks]

@Phylu oddly I now get the following error when I try to run that test on this branch:

./resource_aws_secret_backend_role.go:48:5: cannot use util.JsonDiffSuppress (type func(string, string, string, *"github.com/terraform-providers/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/schema".ResourceData) bool) as type "github.com/Phylu/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/schema".SchemaDiffSuppressFunc in field value
./resource_aws_secret_backend_role_test.go:33:36: cannot use util.TestCheckResourceAttrJSON("vault_aws_secret_backend_role.test_policy_inline", "policy", testAccAWSSecretBackendRolePolicyInline_basic) (type "github.com/terraform-providers/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".TestCheckFunc) as type "github.com/Phylu/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".TestCheckFunc in argument to "github.com/Phylu/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".ComposeTestCheckFunc
./resource_aws_secret_backend_role_test.go:44:36: cannot use util.TestCheckResourceAttrJSON("vault_aws_secret_backend_role.test_policy_inline", "policy", testAccAWSSecretBackendRolePolicyInline_updated) (type "github.com/terraform-providers/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".TestCheckFunc) as type "github.com/Phylu/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".TestCheckFunc in argument to "github.com/Phylu/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".ComposeTestCheckFunc
./resource_aws_secret_backend_role_test.go:68:36: cannot use util.TestCheckResourceAttrJSON("vault_aws_secret_backend_role.test_policy_inline", "policy", testAccAWSSecretBackendRolePolicyInline_basic) (type "github.com/terraform-providers/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".TestCheckFunc) as type "github.com/Phylu/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".TestCheckFunc in argument to "github.com/Phylu/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".ComposeTestCheckFunc
./resource_aws_secret_backend_role_test.go:102:36: cannot use util.TestCheckResourceAttrJSON("vault_aws_secret_backend_role.test_policy_inline", "policy", testAccAWSSecretBackendRolePolicyInline_basic) (type "github.com/terraform-providers/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".TestCheckFunc) as type "github.com/Phylu/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".TestCheckFunc in argument to "github.com/Phylu/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".ComposeTestCheckFunc
./resource_aws_secret_backend_role_test.go:113:36: cannot use util.TestCheckResourceAttrJSON("vault_aws_secret_backend_role.test_policy_inline", "policy", testAccAWSSecretBackendRolePolicyInline_updated) (type "github.com/terraform-providers/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".TestCheckFunc) as type "github.com/Phylu/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".TestCheckFunc in argument to "github.com/Phylu/terraform-provider-vault/vendor/github.com/hashicorp/terraform/helper/resource".ComposeTestCheckFunc

I think the current master branch of the Terraform Vault Provider may just need to be merged in.

[Phylu]

That is very strange. Might it be an issue if you ran the tests in my repository, as some links to files in the vendor folder might be wrong?

I just merged the current master and ran the acceptance tests again and everything seems fine. Let's see what travis says here. If I can do anything more, just let me know.

[tyrannosaurus-becks]

@Phylu yes, it did turn out to be an issue with my test environment. Thank you! This is looking fantastic and all tests are passing.

[Phylu]

@Phylu yes, it did turn out to be an issue with my test environment. Thank you! This is looking fantastic and all tests are passing.

Nice. Thanks!