Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support missing token parameters on vault_okta_auth_backend resource #2210

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Support missing token parameters on vault_okta_auth_backend resource #2210

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
02176e2
add token fields to okta auth backend config resource
vinay-gopalan Mar 25, 2024
3571492
merge main
vinay-gopalan Jun 6, 2024
b5be857
fix tests and remove legacy code
vinay-gopalan Jun 11, 2024
6b14efc
update fields to use constants
vinay-gopalan Jun 11, 2024
a6cd17e
remove unnecessary computed additions
vinay-gopalan Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/consts/consts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,7 @@ const (
MountTypeTerraform = "terraform"
MountTypeNone = "none"
MountTypeSAML = "saml"
MountTypeOkta = "okta"

/*
Vault version constants
Expand Down
2 changes: 2 additions & 0 deletions vault/auth_token.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ func addTokenFields(fields map[string]*schema.Schema, config *addTokenFieldsConf
Type: schema.TypeInt,
Description: "The maximum lifetime of the generated token",
Optional: true,
Computed: true,
ConflictsWith: config.TokenMaxTTLConflict,
}

Expand Down Expand Up @@ -112,6 +113,7 @@ func addTokenFields(fields map[string]*schema.Schema, config *addTokenFieldsConf
Type: schema.TypeInt,
Description: "The initial ttl of the token to generate in seconds",
Optional: true,
Computed: true,
ConflictsWith: config.TokenTTLConflict,
}

Expand Down
Loading
Loading